-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Add runtime transaction sender and receiver Eth address #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aefhm
changed the title
Xz/3u9y3yp add transaction sender eth address
api: Add transaction sender Eth address
Feb 6, 2023
aefhm
added
enhancement
New feature or request
good first issue
Good for newcomers
api-layer
API layer-related issues.
p1
labels
Feb 6, 2023
aefhm
commented
Feb 6, 2023
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
from
February 6, 2023 06:29
26a80ad
to
3ee53e1
Compare
aefhm
commented
Feb 6, 2023
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
3 times, most recently
from
February 9, 2023 05:23
fd188cc
to
7b03d00
Compare
mitjat
reviewed
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Xi!
Largely LGTM, with a performance concern where I'd like to ask you for some more reassurances/testing.
Andrew7234
approved these changes
Feb 15, 2023
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
from
February 15, 2023 05:33
ce10298
to
cef0922
Compare
aefhm
commented
Feb 15, 2023
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
5 times, most recently
from
February 16, 2023 23:38
251691f
to
781ba43
Compare
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
2 times, most recently
from
February 21, 2023 05:45
9630d9a
to
77c6aa1
Compare
mitjat
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Xi and Warren!
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
6 times, most recently
from
February 23, 2023 01:18
93d1e0a
to
eb6cbd7
Compare
aefhm
force-pushed
the
xz/3u9y3yp-add-transaction-sender-eth-address
branch
from
February 23, 2023 22:07
eb6cbd7
to
f13824a
Compare
aefhm
changed the title
api: Add transaction sender Eth address
api: Add transaction sender and receiver Eth address
Feb 23, 2023
aefhm
changed the title
api: Add transaction sender and receiver Eth address
api: Add runtime transaction sender and receiver Eth address
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-layer
API layer-related issues.
enhancement
New feature or request
good first issue
Good for newcomers
p1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address https://app.clickup.com/t/3u9y3yp and add Eth address to API endpoint
TODO