Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Add runtime transaction sender and receiver Eth address #310

Merged
merged 3 commits into from
Feb 23, 2023
Merged

api: Add runtime transaction sender and receiver Eth address #310

merged 3 commits into from
Feb 23, 2023

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Feb 6, 2023 •
edited
Loading

Description

Address https://app.clickup.com/t/3u9y3yp and add Eth address to API endpoint

TODO

  • perf check
  • solve perf problem
  • investigate missing preimage

@aefhm aefhm changed the title Xz/3u9y3yp add transaction sender eth address api: Add transaction sender Eth address Feb 6, 2023
@aefhm aefhm self-assigned this Feb 6, 2023
@aefhm aefhm added enhancement New feature or request good first issue Good for newcomers api-layer API layer-related issues. p1 labels Feb 6, 2023
aefhm
aefhm commented Feb 6, 2023
View reviewed changes
api/spec/v1.yaml Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch from 26a80ad to 3ee53e1 Compare February 6, 2023 06:29
aefhm
aefhm commented Feb 6, 2023
View reviewed changes
api/v1/strict_server.go Outdated Show resolved Hide resolved
@aefhm aefhm marked this pull request as ready for review February 6, 2023 16:55
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch 3 times, most recently from fd188cc to 7b03d00 Compare February 9, 2023 05:23
mitjat
mitjat reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Xi!
Largely LGTM, with a performance concern where I'd like to ask you for some more reassurances/testing.

api/v1/logic.go Outdated Show resolved Hide resolved
storage/client/queries.go Outdated Show resolved Hide resolved
storage/client/types.go Outdated Show resolved Hide resolved
storage/client/queries.go Outdated Show resolved Hide resolved
api/spec/v1.yaml Outdated Show resolved Hide resolved
api/spec/v1.yaml Outdated Show resolved Hide resolved
@mitjat mitjat mentioned this pull request Feb 14, 2023
Merged
Andrew7234
Andrew7234 approved these changes Feb 15, 2023
View reviewed changes
api/spec/v1.yaml Outdated Show resolved Hide resolved
api/v1/logic.go Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch from ce10298 to cef0922 Compare February 15, 2023 05:33
aefhm
aefhm commented Feb 15, 2023
View reviewed changes
storage/client/queries.go Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch 5 times, most recently from 251691f to 781ba43 Compare February 16, 2023 23:38
@pro-wh pro-wh mentioned this pull request Feb 17, 2023
Merged
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch 2 times, most recently from 9630d9a to 77c6aa1 Compare February 21, 2023 05:45
mitjat
mitjat approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Xi and Warren!

storage/client/queries.go Outdated Show resolved Hide resolved
analyzer/uncategorized/addresses.go Outdated Show resolved Hide resolved
analyzer/uncategorized/addresses.go Outdated Show resolved Hide resolved
analyzer/uncategorized/addresses.go Outdated Show resolved Hide resolved
api/spec/v1.yaml Outdated Show resolved Hide resolved
storage/client/queries.go Outdated Show resolved Hide resolved
storage/client/queries.go Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch 6 times, most recently from 93d1e0a to eb6cbd7 Compare February 23, 2023 01:18
@aefhm aefhm force-pushed the xz/3u9y3yp-add-transaction-sender-eth-address branch from eb6cbd7 to f13824a Compare February 23, 2023 22:07
@aefhm aefhm changed the title api: Add transaction sender Eth address api: Add transaction sender and receiver Eth address Feb 23, 2023
@aefhm aefhm changed the title api: Add transaction sender and receiver Eth address api: Add runtime transaction sender and receiver Eth address Feb 23, 2023
@aefhm aefhm enabled auto-merge February 23, 2023 22:10
@aefhm aefhm merged commit e3e260f into main Feb 23, 2023
@aefhm aefhm deleted the xz/3u9y3yp-add-transaction-sender-eth-address branch February 23, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitjat mitjat mitjat approved these changes

@Andrew7234 Andrew7234 Andrew7234 approved these changes

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees

@aefhm aefhm

Labels
api-layer API layer-related issues. enhancement New feature or request good first issue Good for newcomers p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aefhm @mitjat @Andrew7234 @pro-wh