Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node suspension due to runtime liveness failures #4470

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 9, 2022

TODO

  • Basic structures for tracking node liveness faults.
  • Update the scheduler service to ignore suspended nodes when electing committees.
  • Update the roothash service to track node liveness failure in the previous epoch.
  • Support for slashing.
  • Tests.

@kostko kostko added c:roothash Category: root hash service c:breaking/consensus Category: breaking consensus changes labels Feb 9, 2022
@kostko kostko force-pushed the kostko/feature/rt-liveness-penalties branch 3 times, most recently from 8ba7f5a to 25f5b1c Compare February 11, 2022 14:19
@kostko kostko marked this pull request as ready for review February 11, 2022 14:21
@kostko kostko force-pushed the kostko/feature/rt-liveness-penalties branch 3 times, most recently from 3d5305a to ae7679d Compare February 15, 2022 11:17
@kostko kostko force-pushed the kostko/feature/rt-liveness-penalties branch from ae7679d to 9bfcaf8 Compare February 15, 2022 12:37
Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs fixgenesis support, because we presumably want to enable this behavior.

@kostko
Copy link
Member Author

kostko commented Feb 15, 2022

My thinking was to leave it up to a runtime descriptor update.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #4470 (9bfcaf8) into master (b4de534) will decrease coverage by 0.10%.
The diff coverage is 77.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4470      +/-   ##
==========================================
- Coverage   68.87%   68.76%   -0.11%     
==========================================
  Files         421      424       +3     
  Lines       47174    47357     +183     
==========================================
+ Hits        32489    32566      +77     
- Misses      10697    10762      +65     
- Partials     3988     4029      +41     
Impacted Files Coverage Δ
go/registry/api/runtime.go 43.94% <0.00%> (-0.57%) ⬇️
go/consensus/tendermint/apps/roothash/slashing.go 67.32% <41.17%> (-5.30%) ⬇️
go/consensus/tendermint/api/context.go 88.63% <50.00%> (ø)
go/consensus/tendermint/governance/governance.go 63.76% <50.00%> (ø)
go/consensus/tendermint/staking/staking.go 61.13% <50.00%> (ø)
go/consensus/tendermint/scheduler/scheduler.go 58.02% <60.00%> (ø)
go/consensus/tendermint/beacon/beacon.go 72.24% <62.50%> (ø)
go/consensus/tendermint/roothash/roothash.go 68.07% <63.63%> (+0.31%) ⬆️
go/consensus/tendermint/registry/registry.go 66.18% <65.00%> (-2.42%) ⬇️
...o/consensus/tendermint/apps/scheduler/scheduler.go 71.33% <73.68%> (+0.19%) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcdb043...9bfcaf8. Read the comment docs.

@kostko kostko merged commit 52105d9 into master Feb 15, 2022
@kostko kostko deleted the kostko/feature/rt-liveness-penalties branch February 15, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:roothash Category: root hash service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants