-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/keymanager/api: Move key manager gas costs #5166
Conversation
f755418
to
1179f0f
Compare
Codecov Report
@@ Coverage Diff @@
## master #5166 +/- ##
==========================================
+ Coverage 66.73% 66.91% +0.17%
==========================================
Files 497 499 +2
Lines 53300 53357 +57
==========================================
+ Hits 35570 35704 +134
+ Misses 13363 13291 -72
+ Partials 4367 4362 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
go/keymanager/api/api.go
Outdated
const ( | ||
// GasOpUpdateKeyManager is the gas operation identifier for key manager | ||
// policy updates costs. | ||
GasOpUpdateKeyManager transaction.Op = "update_keymanager" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be called GasOpUpdatePolicy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also rename "update_keymanager"
to "update_policy"
and then remove "update_keymanager"
in the fix genesis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that makes the most sense.
1179f0f
to
f445152
Compare
f445152
to
b4f54d5
Compare
Moving key manager gas costs from registry to key manager.