go/keymanager/api: Move key manager gas costs #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/breaking/km-gas-costs
branch
3 times, most recently
from
f755418
to
1179f0f
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5166 +/- ##
==========================================
+ Coverage 66.73% 66.91% +0.17%
==========================================
Files 497 499 +2
Lines 53300 53357 +57
==========================================
+ Hits 35570 35704 +134
+ Misses 13363 13291 -72
+ Partials 4367 4362 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kostko
approved these changes
Feb 6, 2023
go/keymanager/api/api.go
Outdated
| const ( | ||
| // GasOpUpdateKeyManager is the gas operation identifier for key manager | ||
| // policy updates costs. | ||
| GasOpUpdateKeyManager transaction.Op = "update_keymanager" |
There was a problem hiding this comment.
This should probably be called GasOpUpdatePolicy.
There was a problem hiding this comment.
Should I also rename "update_keymanager" to "update_policy" and then remove "update_keymanager" in the fix genesis?
There was a problem hiding this comment.
Yeah I think that makes the most sense.
peternose
force-pushed
the
peternose/breaking/km-gas-costs
branch
from
1179f0f
to
f445152
Compare
peternose
force-pushed
the
peternose/breaking/km-gas-costs
branch
from
f445152
to
b4f54d5
Compare
kostko
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving key manager gas costs from registry to key manager.