keymanager: Support policies in unsafe builds #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5215 +/- ##
==========================================
+ Coverage 61.30% 61.53% +0.23%
==========================================
Files 512 512
Lines 54246 54243 -3
==========================================
+ Hits 33256 33381 +125
+ Misses 16754 16633 -121
+ Partials 4236 4229 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kostko
approved these changes
Mar 8, 2023
| Runtime int `json:"runtime"` | ||
| Entity int `json:"entity"` | ||
| Policy int `json:"policy"` | ||
| SkipPolicy bool `json:"skip_policy"` |
There was a problem hiding this comment.
Suggested change
| SkipPolicy bool `json:"skip_policy"` | |
| SkipPolicy bool `json:"skip_policy,omitempty"` |
The key manager settings configured in the policy can now be tested on non-SGX builds as well. This will simplify tests, as default values can be configured in the test fixtures (e.g. master secret rotation period).
peternose
force-pushed
the
peternose/internal/allow_policies_in_insecure_builds
branch
from
4ba2bc0
to
2490d26
Compare
peternose
deleted the
peternose/internal/allow_policies_in_insecure_builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key manager settings configured in the policy can now be tested on non-SGX builds as well. This will simplify tests, as default values can be configured in the test fixtures (e.g. master secret rotation period).