Reverse TCB fetch order #5704
Merged
Reverse TCB fetch order #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
kostko
reviewed
May 24, 2024
go/runtime/host/sgx/epid.go
Outdated
| @@ -135,8 +137,8 @@ func (ep *teeStateEPID) update( | |||
| // Decode the AVR so we can do further checks. | |||
| avr, decErr := cmnIAS.UnsafeDecodeAVR(avrBundle.Body) | |||
| if decErr == nil && avr.TCBEvaluationDataNumber < quotePolicy.MinTCBEvaluationDataNumber { | |||
There was a problem hiding this comment.
This condition needs to be changed as early TCB updates will always have higher or equal TCBEvaluationDataNumber. Instead we should probably check that avr.ISVEnclaveQuoteStatus is not one of QuoteOK or QuoteSwHardeningNeeded and only in this case fall back to "without early updating".
jberci
force-pushed
the
jberci/feat/tcb-reorder
branch
from
3381a06
to
993c30c
Compare
jberci
requested review from
peterjgilbert,
pro-wh,
ptrus and
peternose
as code owners
kostko
reviewed
May 24, 2024
jberci
force-pushed
the
jberci/feat/tcb-reorder
branch
from
993c30c
to
09a2c65
Compare
kostko
approved these changes
May 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5704 +/- ##
==========================================
+ Coverage 64.98% 65.59% +0.61%
==========================================
Files 618 618
Lines 63185 63186 +1
==========================================
+ Hits 41061 41449 +388
+ Misses 17294 16905 -389
- Partials 4830 4832 +2 ☔ View full report in Codecov by Sentry. |
peternose
reviewed
May 24, 2024
peternose
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.