runtimes: add related transactions index by tx #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Andrew7234
approved these changes
Feb 17, 2023
aefhm
reviewed
Feb 19, 2023
| @@ -73,7 +73,7 @@ CREATE TABLE oasis_3.runtime_related_transactions | |||
| tx_index UINT31 NOT NULL, | |||
| FOREIGN KEY (runtime, tx_round, tx_index) REFERENCES oasis_3.runtime_transactions(runtime, round, tx_index) DEFERRABLE INITIALLY DEFERRED | |||
| ); | |||
| CREATE INDEX ix_runtime_related_transactions_address_height_index ON oasis_3.runtime_related_transactions (account_address, tx_round, tx_index); | |||
There was a problem hiding this comment.
Ohh, I didn't know that you could get transitive properties in indices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #310, we want to look up related addresses by transaction. add an index so that we can quickly get those and pull the address preimages
also some indexes didn't get the
runtimecolumn added when we unified the runtime tables in #296. adding it