Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define and automate project's versioning #122

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Dec 1, 2020

Use Punch tool for tracking and bumping project's version.

Part of #55.

Use Punch tool for tracking and bumping project's version.
Copy link
Collaborator

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tjanez tjanez marked this pull request as ready for review December 2, 2020 10:35
Copy link
Contributor

@abukosek abukosek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of sticking this release stuff into the Makefile (it should be a shell script) nor is it good to run some random python scripts on every invocation of make, however, we already had that discussion previously on Slack -- if you're really going to fix this at some later time, then it's fine with me :)
Semantic versioning looks like a good choice 👍

@tjanez
Copy link
Member Author

tjanez commented Dec 2, 2020

I'm not a fan of sticking this release stuff into the Makefile (it should be a shell script)

Yeah, sticking all this into a Makefile is quite heavy 🙂. I agree we need to come up with something better in the future, preferably something that can be shared among repos (i.e. Oasis Core, Oasis Core Ledger).

nor is it good to run some random python scripts on every invocation of make,

If you mean the Punch tool, then this has been improved and it is only called when running the changelog Make target to bump the version appropriately.

however, we already had that discussion previously on Slack -- if you're really going to fix this at some later time, then it's fine with me :)

I won't mind if someone else also takes a stab at trying to improve our tooling 🙂.

@tjanez tjanez merged commit f6777a5 into master Dec 2, 2020
@tjanez tjanez deleted the tjanez/add-versioning branch December 2, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants