-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Add support for address book #1087
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
- Coverage 67.88% 67.80% -0.09%
==========================================
Files 131 131
Lines 11585 11584 -1
==========================================
- Hits 7865 7855 -10
- Misses 3688 3697 +9
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
84f2f6c
to
ac68b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't think that conflating this with the usual wallet accounts is a good idea. I would add a new configuration section called address book which is explicitly made just for storing addresses and then support this as an additional address resolution source.
f56ea46
to
898308c
Compare
199776b
to
251e4dc
Compare
251e4dc
to
e5b6e51
Compare
e5b6e51
to
1c7fc4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, left some minor comments and then it should be good to go!
4f5af6e
to
6a4cf44
Compare
6a4cf44
to
2d9998b
Compare
52364e6
to
dadcae3
Compare
This enables labeling native oasis or ethereum addresses and using them for transfers, withdrawals, deposits etc.
dadcae3
to
785de04
Compare
Fixes #892
addressbook
command with subcommandsadd
,rm
,rename
,list
andshow
Example: