Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evm: allow unencrypted calls #1256

Merged
merged 1 commit into from
Feb 6, 2023
Merged

evm: allow unencrypted calls #1256

merged 1 commit into from
Feb 6, 2023

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Feb 4, 2023

This PR changes confidential EVM to accept all calls instead of just enveloped ones. This makes it easier to accidentally send public transactions, but it makes it harder for third-party tooling to integrate. We could make the gateway more restrictive instead of the runtime. The gateway would see a mistakenly unencrypted tx anyway.

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Merging #1256 (351f441) into main (5e03536) will increase coverage by 0.99%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main    #1256      +/-   ##
==========================================
+ Coverage   66.94%   67.93%   +0.99%     
==========================================
  Files         132      133       +1     
  Lines       12317    12562     +245     
==========================================
+ Hits         8245     8534     +289     
+ Misses       4042     3998      -44     
  Partials       30       30              
Impacted Files Coverage Δ
runtime-sdk/modules/evm/src/test.rs 67.62% <77.77%> (+0.31%) ⬆️
runtime-sdk/modules/evm/src/lib.rs 50.83% <85.71%> (+0.33%) ⬆️
runtime-sdk/src/callformat.rs 63.56% <0.00%> (-0.78%) ⬇️
contract-sdk/specs/token/oas20/src/types.rs 71.42% <0.00%> (ø)
contract-sdk/specs/token/oas20/src/lib.rs 58.25% <0.00%> (+58.25%) ⬆️
contract-sdk/specs/token/oas20/src/helpers.rs 78.97% <0.00%> (+78.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nhynes nhynes merged commit 1667b8e into main Feb 6, 2023
@nhynes nhynes deleted the nhynes/evm-allow-unencrypted branch February 6, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants