Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-sdk: Permanently enable schedule control #888

Merged
merged 4 commits into from
Apr 15, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 14, 2022

Given upcoming oasisprotocol/oasis-core#4665 which will mandate runtime schedule control, this makes schedule control always enabled.

@kostko kostko added the c:runtime-sdk Category: Runtime SDK label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #888 (8a633e7) into main (e2d9753) will decrease coverage by 0.35%.
The diff coverage is 11.90%.

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   70.65%   70.29%   -0.36%     
==========================================
  Files         118      119       +1     
  Lines        9309     9228      -81     
==========================================
- Hits         6577     6487      -90     
- Misses       2709     2718       +9     
  Partials       23       23              
Impacted Files Coverage Δ
runtime-sdk/src/config.rs 0.00% <0.00%> (ø)
runtime-sdk/src/module.rs 46.20% <0.00%> (-2.25%) ⬇️
runtime-sdk/src/modules/core/mod.rs 78.50% <0.00%> (-2.26%) ⬇️
runtime-sdk/src/modules/core/test.rs 96.00% <0.00%> (-1.00%) ⬇️
runtime-sdk/src/runtime.rs 18.18% <0.00%> (+0.27%) ⬆️
runtime-sdk/src/dispatcher.rs 12.37% <18.51%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d9753...8a633e7. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rt-txpool-update branch 2 times, most recently from 7cbe116 to 489f6bf Compare April 15, 2022 07:47
@kostko kostko marked this pull request as ready for review April 15, 2022 07:50
client-sdk/go/modules/core/types.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/rt-txpool-update branch from 489f6bf to 8a633e7 Compare April 15, 2022 11:27
@kostko kostko enabled auto-merge April 15, 2022 11:37
@kostko kostko merged commit f4a4401 into main Apr 15, 2022
@kostko kostko deleted the kostko/feature/rt-txpool-update branch April 15, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:runtime-sdk Category: Runtime SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants