Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some dependencies are unused #9

Closed
lukaw3d opened this issue Aug 11, 2021 · 1 comment · Fixed by #85
Closed

Some dependencies are unused #9

lukaw3d opened this issue Aug 11, 2021 · 1 comment · Fixed by #85
Labels
p:1 Priority: core feature

Comments

@lukaw3d
Copy link
Member

lukaw3d commented Aug 11, 2021

Unused dependencies

  • bip32
  • bn.js
  • bs58check
  • elliptic
  • identicon.js
  • js-sha256
  • js-sha512
  • react-compound-slider

Missing dependencies
@aefhm aefhm mentioned this issue Aug 17, 2021
Open
@peterjgilbert peterjgilbert added the p:1 Priority: core feature label Aug 17, 2021
@peterjgilbert
Copy link
Contributor

@lvshaoping007 can you address this one?

lvshaoping007 added a commit to lvshaoping007/oasis-wallet-ext that referenced this issue Aug 20, 2021
@lvshaoping007
oasisprotocol#6 oasisprotocol#7 oasisprotocol#9 fix
63fe829
@lukaw3d lukaw3d mentioned this issue Aug 20, 2021
Closed
This was referenced Aug 22, 2021
Closed
Closed
lvshaoping007 added a commit to lvshaoping007/oasis-wallet-ext that referenced this issue Aug 24, 2021
@lvshaoping007
oasisprotocol#7 oasisprotocol#9 fix
9a014cb
@lvshaoping007 lvshaoping007 mentioned this issue Aug 24, 2021
Closed
lvshaoping007 added a commit to lvshaoping007/oasis-wallet-ext that referenced this issue Aug 24, 2021
@lvshaoping007
oasisprotocol#7,oasisprotocol#9 fix
605c65e
This was referenced Aug 24, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:1 Priority: core feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused dependencies and properly separate dev dependencies lvshaoping007/oasis-wallet-ext
2 participants
@peterjgilbert @lukaw3d