Fix extension connecting to ledger by opening a normal window, not headless popup #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
lukaw3d
force-pushed
the
lw/ledger-popup-broken
branch
from
e4375d0
to
56823f1
Compare
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
==========================================
- Coverage 84.76% 84.60% -0.17%
==========================================
Files 142 142
Lines 3611 3604 -7
Branches 660 661 +1
==========================================
- Hits 3061 3049 -12
- Misses 550 555 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lukaw3d
force-pushed
the
lw/ledger-popup-broken
branch
4 times, most recently
from
ba8aea2
to
b61c9a8
Compare
buberdds
approved these changes
Mar 17, 2023
But test still fails: Chromium auto-rejects permissions dialog.
lukaw3d
force-pushed
the
lw/ledger-popup-broken
branch
from
b61c9a8
to
6cca060
Compare
lukaw3d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to oasisprotocol/oasis-wallet-ext#302 and oasisprotocol/oasis-wallet-ext#301