Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opl-secret-ballot #5

Merged
merged 4 commits into from
Jun 7, 2023
Merged

Add opl-secret-ballot #5

merged 4 commits into from
Jun 7, 2023

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Apr 20, 2023

Why

Add example code to support documentation and tutorials.

@aefhm aefhm requested a review from matevz April 20, 2023 20:10
@aefhm aefhm marked this pull request as draft April 20, 2023 20:11
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for the initial migratiom. I'll test it tomorrow and let you know if I run into any issues.

The only thing that bothers me is whether the folder should be called secret-ballot-opl instead - If we make another non-opl version of the ballot. This would need a change in all package.json files though (eg. @oasislabs/secret-ballot-opl-frontend).

opl-secret-ballot/LICENSE Outdated Show resolved Hide resolved
@aefhm aefhm marked this pull request as ready for review June 6, 2023 16:34
@aefhm
Copy link
Contributor Author

aefhm commented Jun 6, 2023

Seems fine for the initial migratiom. I'll test it tomorrow and let you know if I run into any issues.

The only thing that bothers me is whether the folder should be called secret-ballot-opl instead - If we make another non-opl version of the ballot. This would need a change in all package.json files though (eg. @oasislabs/secret-ballot-opl-frontend).

Hmm. I think it is okay to make that change in the future or that resetting a tutorial is reasonable.

@matevz matevz merged commit d6c4956 into main Jun 7, 2023
@matevz matevz deleted the xz/add-opl-secret-ballot branch June 7, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants