Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screenshots after switching projects #64

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Fix screenshots after switching projects #64

merged 1 commit into from
Jul 4, 2024

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented May 27, 2024

Before:

  • open 0x2FA project
  • switch to second screenshot
  • close and open Authenticator Demo project
  • see broken carousel for 5 seconds

playground oasis io_

@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-playground ready!

Name Link
🔨 Latest commit 43aba9e
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-playground/deploys/668614b7eef5b40008dc3311
😎 Deploy Preview https://deploy-preview-64--oasisprotocol-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lukaw3d lukaw3d force-pushed the lw/switch-project-screenshots branch from 1a418de to 43aba9e Compare July 4, 2024 03:19
matevz
matevz approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@lukaw3d lukaw3d merged commit 25589bd into main Jul 4, 2024
4 checks passed
@lukaw3d lukaw3d deleted the lw/switch-project-screenshots branch July 4, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

@kaja-osojnik kaja-osojnik Awaiting requested review from kaja-osojnik

Assignees

@matevz matevz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaw3d @matevz