Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more functionalities to cipher to reuse #87

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

xmzheng
Copy link
Contributor

@xmzheng xmzheng commented Nov 20, 2022

No description provided.

@xmzheng xmzheng requested a review from nhynes November 20, 2022 05:36
@xmzheng
Copy link
Contributor Author

xmzheng commented Nov 20, 2022

I will add unit tests after we agree the format

Copy link
Contributor

@nhynes nhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had a few comments that you can apply before merging.

clients/js/src/cipher.ts Outdated Show resolved Hide resolved
clients/js/src/cipher.ts Outdated Show resolved Hide resolved
clients/js/src/cipher.ts Outdated Show resolved Hide resolved
@xmzheng xmzheng force-pushed the xmzheng/more-cipher-decode-encode branch from f10e799 to 77fbca9 Compare December 5, 2022 03:26
@xmzheng xmzheng force-pushed the xmzheng/more-cipher-decode-encode branch from 77fbca9 to 6ae2a2c Compare December 6, 2022 16:42
@xmzheng xmzheng merged commit 1b0f501 into main Dec 6, 2022
@xmzheng xmzheng deleted the xmzheng/more-cipher-decode-encode branch December 6, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants