This repository has been archived by the owner on Nov 23, 2021. It is now read-only.
Spring boot upgrade issue with mysql and postgresql (fix for issue #674) #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hohwille
suggested changes
Aug 30, 2018
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <entity-mappings version="1.0" xmlns="http://java.sun.com/xml/ns/persistence/orm" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://java.sun.com/xml/ns/persistence/orm http://java.sun.com/xml/ns/persistence/orm_1_0.xsd"> | ||
| #if ($dbType == 'mysql') |
There was a problem hiding this comment.
After working this through I think that mariadb should be treated the same as it is a fork of mysql with the same behavior. Is that correct or am I missing something?
There was a problem hiding this comment.
I have tested it with mysql, postgres, h2 and oracle. will test it with mariadb and if require I will change it accordingly
There was a problem hiding this comment.
Done the required changes for mariadb
hohwille
changed the title
|
Updated with the review comments for mariadb |
hohwille
approved these changes
Aug 30, 2018
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <entity-mappings version="1.0" xmlns="http://java.sun.com/xml/ns/persistence/orm" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://java.sun.com/xml/ns/persistence/orm http://java.sun.com/xml/ns/persistence/orm_1_0.xsd"> | ||
| #if ($dbType == 'mysql' || $dbType == 'mariadb') |
This was referenced Aug 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this PR is for issue #680 , which is extentsion to issue #674
So this PR includes review suggested in PR #677 and also the issue related to postgres.
So now we can close the PR #677 without merging and considered this as final PR