Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Replaced old CSRF token protection with new method #87

Merged
merged 11 commits into from
May 2, 2019
Merged

[WIP] - Replaced old CSRF token protection with new method #87

merged 11 commits into from
May 2, 2019

Conversation

martijn-tao
Copy link
Contributor

@martijn-tao martijn-tao commented Mar 25, 2019 •
edited by siwane

@martijn-tao martijn-tao mentioned this pull request Mar 25, 2019
Merged
13 tasks
krampstudio
krampstudio suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@krampstudio krampstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following error by trying to update the permissions (no token in headers, response as no body and status code is 412)
image

@oatymart oatymart requested a review from krampstudio May 2, 2019 08:17
krampstudio
krampstudio suggested changes May 2, 2019
View reviewed changes
Copy link
Contributor

@krampstudio krampstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment below to prevent an unhandled promise rejection
Except that point the bug above is fixed.

views/js/controller/admin/index.js Show resolved Hide resolved
krampstudio
krampstudio approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@krampstudio krampstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me !

@siwane siwane marked this pull request as ready for review May 2, 2019 14:49
@siwane siwane merged commit 8de527c into develop May 2, 2019
@siwane siwane deleted the feature/TAO-7306-Implement-endpoint-CSRF-protection branch May 2, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oatymart oatymart oatymart left review comments

@krampstudio krampstudio krampstudio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martijn-tao @krampstudio @oatymart @siwane