Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin adjusted to met a new requirements from Composer 2.0 #6

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

alroniks
Copy link
Contributor

As Composer 2.0 is coming soon, they introduce changes in their plugins API, and these changes adjust the code to be compatible with the second version or composer plugins API.

Upgrade was done accordingly to this guide composer/composer#8726

@boajer
Copy link
Contributor

boajer commented Apr 16, 2020

I've tested this plugin with composer v1 and v2 and installed oat-sa/generis#771 as the only extension. It works.

@gitromba gitromba self-requested a review October 26, 2020 10:11
@gitromba
Copy link

gitromba commented Oct 26, 2020

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@gitromba
Copy link

Same - successful - results when testing locally oat-sa/generis#771.

Copy link

@gitromba gitromba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is your plan with the release @alroniks? Will you bump the major version?

@alroniks
Copy link
Contributor Author

@gitromba I don't think that we have to bump the major version, minor will be enough because it does not break any backward compatibility but brings compatibility with the new version of Composer. As it simple PHP library, we don't have to set a version somewhere in the code, one thing that should be done just draft release after merging a pull request.
Also, in code, we require this library as ~1.1||dev-master that means it will take updates from the branch.

@alroniks alroniks merged commit db5e03f into master Oct 26, 2020
@alroniks alroniks deleted the composer2.0_compatibility branch October 26, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants