-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/tr 825/unexpected error on pattern validation #264
Merged
julien-sebire
merged 8 commits into
develop
from
fix/tr-825/unexpected_error_on_pattern_validation
Apr 13, 2021
Merged
Fix/tr 825/unexpected error on pattern validation #264
julien-sebire
merged 8 commits into
develop
from
fix/tr-825/unexpected_error_on_pattern_validation
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sergei Mikhailov <sergei.mikhailov@taotesting.com>
julien-sebire
requested changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things to make it perfect! :)
test/qtismtest/runtime/expressions/operators/PatternMatchProcessorTest.php
Outdated
Show resolved
Hide resolved
julien-sebire
approved these changes
Apr 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! :-)
julien-sebire
deleted the
fix/tr-825/unexpected_error_on_pattern_validation
branch
April 13, 2021 11:55
This was referenced Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to avoid to escape the caret char from patterns using it as an excluding rule