Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): code coverage reports #275

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

wazelin
Copy link
Member

@wazelin wazelin commented May 10, 2021

This PR replaces the coveralls report parsing by codecov.io, and brings PHP 8 support when generating the code-coverage reports.

Coverage Status

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (develop@47be94f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #275   +/-   ##
==========================================
  Coverage           ?   91.75%           
  Complexity         ?    10099           
==========================================
  Files              ?      922           
  Lines              ?    25222           
  Branches           ?        0           
==========================================
  Hits               ?    23142           
  Misses             ?     2080           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47be94f...fa84334. Read the comment docs.

Copy link
Member

@julien-sebire julien-sebire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the change for coverage report but not the other changes (phpunit version, some code cleaning...)
Try maybe to separate in more than one PR...

after_script:
- ./vendor/bin/coveralls -v
after_success:
- bash <(curl -s https://codecov.io/bash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code coverage can be fixed with minimal change to continue to use coveralls, like we have for LTI package:

Suggested change
- bash <(curl -s https://codecov.io/bash)
- ./vendor/bin/php-coveralls -v

@julien-sebire julien-sebire merged commit 5b02ae9 into develop May 10, 2021
@julien-sebire julien-sebire deleted the fix/code-coverage-reports branch May 10, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants