Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only take a new attempt on beginAttempt for items which endAttempt was invoked to allow skipped items to be navigated freely #298

Merged

Conversation

quintanilhar
Copy link
Contributor

@quintanilhar quintanilhar commented Oct 19, 2021

Ticket

https://oat-sa.atlassian.net/browse/TR-1241

Summary

A test taker can decide to skip an item for non-linear tests with items configured with multiple attempts, however, it should not take an attempt away, it should rather put the item in suspend mode and resume the attempt once the item is displayed again. This is done currently by the action endCandidateSession. This is a valid operation but it's currently calling the endAttempt method underneath.

This PR introduces 2 changes to avoid taking attempts away incorrectly:

1- Remove the endAttempt call from the endCandidationSession method;
2- Add a new condition before considering a new attempt to check if the attempt was really ended by the test taker (with endAttempt call);

Dependencies

No dependencies

…tempt` was invoked to allow skipped items to be navigated freely
Copy link
Member

@julien-sebire julien-sebire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. It seems all good for me.
Thanks for updating the tests.

Copy link
Contributor

@poyuki poyuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@quintanilhar quintanilhar merged commit b851599 into develop Oct 20, 2021
@quintanilhar quintanilhar deleted the fix/TR-1241/attempt-taken-for-non-attempted-items branch October 20, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants