Fix/tr 6116/parse float thousands separator fix #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oatymart
reviewed
Jun 12, 2024
Version
There are 0 BREAKING CHANGE, 0 feature, 3 fixes |
Coverage Report
|
oatymart
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
I see that it's working: TextEntry submits the expected value for all the number formats I tried.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master(ormain) - or is a release -
Bundled code is present if needed -
Version bump is applied if needed (packages AND root) - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
-
Changelog is updated according to changes (if applicable) - Documentation is updated according to changes (if applicable)
wazelin
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/TR-6116
In
locale.js, thethousandsSeparatorwas only replacing the value with an empty string, which caused a bug where the number 3,14 was converted to 314. The expectation is that the number after thethousandsSeparatorwill be ignored and send as 3.To achieve that, I prepared a regex that transforms only groups of 3 digits after the
thousandsSeparatorto a number and ignores less and more than 3 digits.Examples:
3,14 => 3
3,1 => 3
3,123 => 3123
23,123 => 23123
23,1234 =>23