fix/ADF-1146: Distinguish which method requiresRight cached data belongs to #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectoras
changed the title
gabrielfs7
reviewed
Sep 15, 2022
gabrielfs7
reviewed
Sep 15, 2022
gabrielfs7
reviewed
Sep 15, 2022
Co-authored-by: Gabriel Felipe Soares <gabrielfs7@gmail.com>
Co-authored-by: Gabriel Felipe Soares <gabrielfs7@gmail.com>
Co-authored-by: Gabriel Felipe Soares <gabrielfs7@gmail.com>
hectoras
force-pushed
the
fix/ADF-1146-dont-share-docBlock-cache-between-methods
branch
from
1369e8d
to
e8555e3
Compare
hectoras
changed the title
gabrielfs7
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
shpran
approved these changes
Sep 16, 2022
|
Got two approvals, therefore I'm merging this PR in order to start the QA varidation. |
hectoras
deleted the
fix/ADF-1146-dont-share-docBlock-cache-between-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Jira issue: ADF-1146
This fix enables sharing the
@requiresRightcache betweenActionDescriptioninstances while keeping track about which method the cached data belongs to, so it avoids using permissions stored previously for a different action in later calls.There are also two small changes introduced while debugging to avoid errors when running TAO in PHP 8:
strlen()with anullvalue.Related PR: oat-sa/extension-tao-item#595 (it has been closed, as this fix in tao-core alone solves the issue)