New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jwt to 2.0.0 #317
Upgrade jwt to 2.0.0 #317
Conversation
Ok, so Can a maintainer chime in when you get a chance? @sferik ? |
Not a maintainer, but I've spent more time worrying about dependency updates than most (I wrote Dependabot). For a gemspec update like this, you want to change the requirement to be a range - in this case Version 2.0 of jwt isn't that breaking, so I think specs should pass on it without any code changes... (And I just checked Travis for this PR - indeed they do.) |
1475dc0
to
401f1c8
Compare
@greysteil awesome, thanks for your help! Let me know if it looks right now. |
Looks 👌 . Given the note in the readme, you might want to email jason@mobomo.com if you want to get this merged, though... |
@jasonschulte @sferik Can we get this merged 😄 ? |
Thank you for contacting me. Currently no one in our company is assigned
to maintain this repo.
I am including our CTO Shawn MacFarland to see what can be done.
…On Wed, Sep 20, 2017 at 7:53 AM, Cristina Matonte ***@***.***> wrote:
@jasonschulte <https://github.com/jasonschulte> @sferik
<https://github.com/sferik> Can we get this merged 😄 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#317 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADWE952SiUrFBI2atNWdf6N5CCL52kvaks5skQragaJpZM4POkBS>
.
|
@jasonschulte any updates? |
Still waiting on direction from our CTO. I'm inviting him to this repo so we can tag him on this thread and he can respond directly. |
@jasonschulte any chance that there will be some movement on this soon? |
@jasonschulte I understand that your team isn't actively maintaining the gem, but this is a pretty safe/easy change. This gem is a blocker to upgrading |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pboling 💯 👏 🥇 😭 thank you |
@pboling when we can expect to see a new version published? |
Any update on getting 1.5.0 out and on rubygems? |
@bruschill @travisofthenorth @dnd @anitsirc @greysteil We are working on getting a release out as soon as possible. There are still some loose ends. All assistance in reviewing open PRs and issues is appreciated! |
Version 2.0.0 of
ruby-jwt
has just been released after being in beta for many months. This PR updates the version used by this gem.