Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jwt to 2.0.0 #317

Merged
merged 2 commits into from Dec 15, 2017
Merged

Upgrade jwt to 2.0.0 #317

merged 2 commits into from Dec 15, 2017

Conversation

travisofthenorth
Copy link

@travisofthenorth travisofthenorth commented Sep 6, 2017

Version 2.0.0 of ruby-jwt has just been released after being in beta for many months. This PR updates the version used by this gem.

@coveralls
Copy link

coveralls commented Sep 6, 2017

Coverage Status

Coverage remained the same at 96.0% when pulling 1475dc0 on travisofthenorth:upgrade-jwt into 452a085 on intridea:master.

@travisofthenorth
Copy link
Author

Ok, so jwt now requires Ruby version >= 2.1. Obviously this prohibits the use of 1.9 and 2.0 which are both used in runs on CI.

Can a maintainer chime in when you get a chance? @sferik ?

@greysteil
Copy link

greysteil commented Sep 6, 2017

Not a maintainer, but I've spent more time worrying about dependency updates than most (I wrote Dependabot).

For a gemspec update like this, you want to change the requirement to be a range - in this case ">= 1.0", "< 3.0". The jwt gem specifies a required ruby version, so older rubies will still install a 1.x version just fine. I'd also leave the line in the Gemfile there - it's there because very old versions of Bundler don't respect the required_ruby_version, but we still want to test against them in the build matrix.

Version 2.0 of jwt isn't that breaking, so I think specs should pass on it without any code changes... (And I just checked Travis for this PR - indeed they do.)

@travisofthenorth
Copy link
Author

@greysteil awesome, thanks for your help! Let me know if it looks right now.

@greysteil
Copy link

Looks 👌 . Given the note in the readme, you might want to email jason@mobomo.com if you want to get this merged, though...

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage remained the same at 96.0% when pulling 401f1c8 on travisofthenorth:upgrade-jwt into 452a085 on intridea:master.

@anitsirc
Copy link

@jasonschulte @sferik Can we get this merged 😄 ?

@jasonschulte
Copy link
Contributor

jasonschulte commented Sep 21, 2017 via email

@anitsirc
Copy link

anitsirc commented Oct 2, 2017

@jasonschulte any updates?

@jasonschulte
Copy link
Contributor

Still waiting on direction from our CTO. I'm inviting him to this repo so we can tag him on this thread and he can respond directly.

@dnd
Copy link

dnd commented Oct 20, 2017

@jasonschulte any chance that there will be some movement on this soon?

@travisofthenorth
Copy link
Author

@jasonschulte I understand that your team isn't actively maintaining the gem, but this is a pretty safe/easy change. This gem is a blocker to upgrading jwt in any application using it, and v2 contains some pretty important fixes. Is there anything I can do to help get this past the finish line?

Copy link
Member

@pboling pboling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pboling pboling merged commit 308d4ba into oauth-xx:master Dec 15, 2017
@travisofthenorth travisofthenorth deleted the upgrade-jwt branch December 15, 2017 20:48
@travisofthenorth
Copy link
Author

travisofthenorth commented Dec 15, 2017

@pboling 💯 👏 🥇 😭 thank you

@travisofthenorth
Copy link
Author

@pboling when we can expect to see a new version published?

@pboling
Copy link
Member

pboling commented Dec 15, 2017

I do not think I have push access to rubygems.org yet. I am working on that. CC @mbleigh @sferik

@josephpage josephpage added this to the 1.5.0 milestone Jan 9, 2018
@bruschill
Copy link

Any update on getting 1.5.0 out and on rubygems?

@pboling
Copy link
Member

pboling commented Mar 1, 2018

@bruschill @travisofthenorth @dnd @anitsirc @greysteil We are working on getting a release out as soon as possible. There are still some loose ends. All assistance in reviewing open PRs and issues is appreciated!
There is no specific timeline for 1.5.0 aside from "as soon as it is ready". Everyone working on the project is pretty new to the project, and we have no desire to mess up a critical piece of software.

@pboling pboling added the in Changelog Has been added to Changelog label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in Changelog Has been added to Changelog
Projects
None yet
9 participants