Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Non-zero exit code #40

Merged
merged 3 commits into from
May 31, 2020
Merged

✨ Non-zero exit code #40

merged 3 commits into from
May 31, 2020

Conversation

obahareth
Copy link
Owner

This will exit with a non-zero code when ES6+ dependencies are detected.

This should fix #29.

Other Changes:

  • I snuck in a small refactor that moved logging into its own class (Logger)

@obahareth obahareth requested a review from tooppaaa May 20, 2020 14:21
tooppaaa
tooppaaa approved these changes May 20, 2020
View reviewed changes
Copy link
Collaborator

@tooppaaa tooppaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change on unit tests and good to go !

tests/logger.test.ts Outdated Show resolved Hide resolved
@obahareth
👌 Update Logger Tests based on Review Feedback
140a06c 
Reorganize tests based on [this comment](#40 (comment)).
@obahareth obahareth requested a review from tooppaaa May 25, 2020 01:42
@obahareth obahareth merged commit 00a094f into master May 31, 2020
@obahareth obahareth deleted the feature/non-zero-exit-code branch May 31, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tooppaaa tooppaaa tooppaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exit with a non-zero code on issues
2 participants
@obahareth @tooppaaa