Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and regression tests #34

Merged
merged 25 commits into from
Nov 6, 2021
Merged

Refactor and regression tests #34

merged 25 commits into from
Nov 6, 2021

Conversation

obalunenko
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #34 (3afc645) into master (c0b0f70) will decrease coverage by 8.49%.
The diff coverage is 84.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   80.96%   72.47%   -8.50%     
==========================================
  Files          14       18       +4     
  Lines        1035     1097      +62     
==========================================
- Hits          838      795      -43     
- Misses        130      231     +101     
- Partials       67       71       +4     
Impacted Files Coverage Δ
cmd/aoc-cli/main.go 7.33% <33.33%> (ø)
internal/puzzles/solutions/2020/day01/solution.go 83.87% <44.44%> (-0.75%) ⬇️
internal/puzzles/solver.go 77.77% <62.50%> (+18.88%) ⬆️
internal/puzzles/solutions/2020/day02/solution.go 85.71% <80.55%> (-4.43%) ⬇️
internal/puzzles/utils/intcomputer/intcomputer.go 60.81% <83.33%> (+0.53%) ⬆️
internal/puzzles/solutions/2017/day01/solution.go 86.95% <90.90%> (+0.19%) ⬆️
internal/puzzles/solutions/2016/day01/solution.go 81.60% <94.87%> (-0.32%) ⬇️
internal/puzzles/day_string.go 100.00% <100.00%> (ø)
internal/puzzles/solutions/2015/day01/solution.go 83.33% <100.00%> (-1.52%) ⬇️
internal/puzzles/solutions/2018/day01/solution.go 85.18% <100.00%> (-0.53%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b0f70...3afc645. Read the comment docs.

@obalunenko obalunenko changed the title chore: Add regression tests for solved puzzles Refactor and regression tests Nov 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.8% 84.8% Coverage
0.0% 0.0% Duplication

@obalunenko obalunenko merged commit 1b79a05 into master Nov 6, 2021
@obalunenko obalunenko deleted the regression-test branch November 6, 2021 12:03
obalunenko added a commit that referenced this pull request Nov 8, 2021
* chore: Add regression tests for solved puzzles

* chore(puzzles/input): Update al inputs with files from site

* chore: update error message

* fix: Add fixes to handle bare input from source files

* refactor(puzzles): Add day and year constants

* refactor: Use day and year constants; trim not necessary fields

* chore(scripts): Remove redundant tag

* chore(puzzles/solutions): add tests for changes

* ci(lint): Exclude revive inter for constants

* chore: add tests for generated code

* chore: Add sonar linters report

* chore: Update linter configs

* chore: Fix linter config

* chore; Udpate ci config

* docs: Add line comments

* refactor: Fix linter warnings

* ci: Add tests-report generation for sonar

* refactor: Fix linter warnings

* refactor: Fix linter warnings

* ci: Fix config

* refactor: Fix linter warnings

* refactor: Fix linters warnings

* refactor: DRY

* chore: Add tests

* refactor: Fix linter warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant