Add support for legacy RSA encoding #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ssh-rsa (RSA_PKCS1_2048_8192_SHA1_FOR_LEGACY_USE_ONLY) which is still used by some legacy systems
|
I know people shouldn't be using the legacy RSA SHA-1 stuff anymore, but there are still use cases where you need to verify them. I'm working on such a project so I needed to make this little change to get it working. |
|
Heyo, thanks for the PR! Could you add some test cases, that way I can see what this covers that it didn't and we can make sure it doesn't get broken in the future? |
|
This is basically what you get when you sign a key using |
|
Awesome, thanks!
…On Wed, Feb 10, 2021 at 6:39 AM Mitchell Grenier ***@***.***> wrote:
Merged #1 <#1> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2UAQAJ4MZH7UJSMRFYZT3S6KLDVANCNFSM4XMFTXIA>
.
--
Digant Chimanlal "DC" Kasundra
|
|
Thanks for contributing! |
|
My pleasure. If I think of some more things, I'll let you know and send you
some PRs (with tests :-D)
…On Wed, Feb 10, 2021 at 9:09 AM Mitchell Grenier ***@***.***> wrote:
Thanks for contributing!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2UAQDI7O2YJCMG5JTXWE3S6K4WFANCNFSM4XMFTXIA>
.
--
Digant Chimanlal "DC" Kasundra
|
|
I've tagged |
|
Awesome, thanks!
…On Wed, Feb 10, 2021 at 1:29 PM Mitchell Grenier ***@***.***> wrote:
I've tagged 0.3.10 with your change included. Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2UAQCKDLR3ZFXLEPJ6P4TS6L3CNANCNFSM4XMFTXIA>
.
--
Digant Chimanlal "DC" Kasundra
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ssh-rsa (RSA_PKCS1_2048_8192_SHA1_FOR_LEGACY_USE_ONLY)
which is still used by some legacy systems.