Jira PRO-308 Oui NotiTray Refactor #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/notification-tray
….com:oberd/oui into feature/pro-262-notification-tray-refactored
nnnnathann
requested changes
Jan 15, 2020
| /* overflow: visible; */ | ||
| } | ||
|
|
||
| oui-nav-bar { |
There was a problem hiding this comment.
Just curious, is there a difference in browser compatibility when using custom element selectors? I'm specifically thinking that older browsers may treat all custom elements as divs and not catch this styling, but don't know, might be fine
There was a problem hiding this comment.
I think it should be fine as long as the browser supports custom elements, but I haven't found much in regards to that specific issue.
|
good work @peterztan , left some comments |
….com:oberd/oui into feature/pro-262-notification-tray-refactored
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored Notification tray, add storybook usages example and vanilla js basic example.