-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes raw_open and microtime on windows #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (Also nice fix for the microtime :P)
@VocalFan have you understand what the code does before approving? As I said before that the rule of thumb is do not approve if you don't understand what the code does. |
Boy, I may be dumb in the deeper things... But we BOTH dived into this code before. |
If you understand then can you explain #773? |
Yep... File_OPEN only reads and opens the file if available, and errors if not available... Though normally, the /dev and /mnt folders already exist, you would... Want a fallback where if it DOES error, then create it with File_CREATE. Thing is it seems we have to do it in this order as File_CREATE just throws an error if the file does already exist. |
Hey, your implementation was broken too, so you can't be mad when we go from a non-working fix to a half-working fix that... If the folders already exist... We reach pub fn open(&self, path: impl AsRef<VPath>, td: Option<&VThread>) -> Result<VFile, OpenError> {
let vnode = self
.lookup(path, true, td)
.map_err(OpenError::LookupFailed)?;
todo!();
} |
https://github.com/obhq/obliteration/blob/main/src/kernel/src/fs/mod.rs#L111-L127 And |
This is actually something I was unsure about and wanted to figure out during the review process. |
No description provided.