Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specimens from TURBO to OBI #1197

Closed
turbomam opened this issue Aug 3, 2020 · 5 comments
Closed

Add specimens from TURBO to OBI #1197

turbomam opened this issue Aug 3, 2020 · 5 comments
Assignees

Comments

@turbomam
Copy link
Contributor

turbomam commented Aug 3, 2020

The TURBO team has defined some specimens required for our assay templating.

Can the contents of
https://github.com/PennTURBO/turbo-ontology/blob/master/ontologies/robot_implementation/more-specimens.tsv

just be added to
https://github.com/obi-ontology/obi/blob/master/src/ontology/templates/biobank-specimens.tsv ?

@turbomam
Copy link
Contributor Author

turbomam commented Aug 3, 2020

If I have requested a new specimen, do I have to additionally add the corresponding anatomical entity (etc.) to something like a OntoAnimals import text file?

@jamesaoverton
Copy link
Contributor

Yes, for anatomical entities, please add them to https://github.com/obi-ontology/obi/blob/master/src/ontology/OntoFox_inputs/Uberon_input.txt and then run make imports.

@turbomam
Copy link
Contributor Author

turbomam commented Aug 5, 2020

@jamesaoverton it looks like I had to manually copy robot.jar into the build directory

But after that it was fast and easy

@turbomam
Copy link
Contributor Author

turbomam commented Aug 5, 2020

@jamesaoverton I have made three commits on the same pull request #1199

sorry, that's probably a pain for you

If forgot to use the established Mac Excel line ending mechanism. I'm going to do that now and push/request again.

@jamesaoverton
Copy link
Contributor

Multiple commits on a PR is not a problem.

Please run make sort to fix the line endings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants