-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Needs to be updated for move to gitlab #18
Comments
Hi,
I'll have a look and get back to you. It should in principle be just about
using got instead of bzr in script but was some months since I tested it
now.
Regards,
Den 10 juni 2017 23:59 skrev "Moini" <notifications@github.com>:
… Hi Olof,
can you let me know if you have the time to update the vagrant file?
This repo was linked from the Inkscape website at https://inkscape.org/en/
develop/getting-started/ , and I had to take it out of it now, because of
the git move. However, I would like to include it again, when the repo has
been updated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEKZvJn3eGKYziMNgGGKqdIJzJ0qPb-ks5sCxGogaJpZM4N2O68>
.
|
Thx, @objarni ! |
I have fiddled around for awhile now, it seems I cannot get Vagrant+VBox to install guest additions (needed for vagrant to function) correctly on my system (Windows 10, VBox 5.1.16, Vagrant 1.9.2), so I am not able to test the switch just now. Do you have a functioning VBox+Vagrant system to test the switch in? |
VBox yes, but I've never used Vagrant. I'm not even sure about how these things will be 'stacked'... I assume that vagrant opens a virtualbox instance and creates or downloads a VM, then logs into it and pulls and builds Inkscape? But I'm going to test your instructions now ;-) |
First issue:
Second issue: Third issue: Fourth issue:
So, I deleted the VM, and tried anew. (btw. it asks me if I want to upgrade to 16.04, when I log in) fifth issue: Dinner is ready, taking a break. |
Thanks for your thourough testing! To answer each of your issues:
|
About docker: I have removed it. It was an attempt to switch from vagrant to docker, however it required the host OS to be Linux, and all necessary binary library dependences to be available too, which just misses the target of inkup (which is to make it easy to get started with inkscape development). |
I have solved (1) and (3); would you mind re-trying "vagrant up" from scratch, that is after removing the previous VM? If that succeeds, I would consider this issue closed. Of course, the general hassle of vagrant/vbox/vbox guest additions versioning does not go away, but it is unrelated to this issue. |
I think 5.) might have been an issue with me not using ls -a, but only ls.... I've looked up if it's possible to only get a single git branch, to reduce the time it takes to clone. |
Ah, great idea! I just tried, the command "git clone https://github.com/inkscape/inkscape.git --single-branch" took less than 15 seconds! Terrific! You or me to add --single-branch? 💃 |
You accidentally used the github repo mirror of Inkscape in your Vagrantfile ;-) |
Can you do both? |
I haven't checked how it works to update such a branch. Hope there are no pitfalls. |
Github, what a mistake! :) I blame Inkup being on Github.. Fixed, and using single-branch clone too. "I haven't checked how it works to update such a branch. " I don't understand what you mean? |
I know that if you do a lightweight bzr checkout, that branch is kind of worthless for updating etc. Was afraid that there may be a similar issue with single-branch git checkouts. |
Running now. |
What is running? Build or Inkscape? About updating, inkup is for exploring and learning inkscape source and build, not really to do merge requests. I would suggest developing in the code base of the VM, and then copying changes to host machine in a proper git/ssh environment. Of course, if you have ideas how to improve that use case (being able to actually push changes on new branches to gitlab), that would be great! |
Sorry for being so unspecific. I meant my next trial with vagrant up. People would need to setup their own ssh keys etc. on the machine - I don't think that can be automated, unless you give prompts to visit gitlab and upload a generated key ;-) I'm on native Ubuntu 16.04 (or rather, Linux Mint 18.1), so if I ever wanted to upload code into the Inkscape repo (which I probably wouldn't without a merge request), I'd do it from my own machine directly. I've started to script the build process, too (for allowing parallel installs, with separate preferences directories and different package names, but only can work on .deb-using systems). Definitely longer than 15 seconds now. Can vagrant redirect the output, so I can read what is happening? |
(There is still network and disk activity on my VM, but that's all I can see) |
Ha, I think I know now why it only took 15 sec for you - you used the near-empty gitlab repo ;-) |
The expected total time from no-image to built inkscape is around 40 minutes on my machine, of course depends on a lot of things. Things that take time:
Checking out the source code actually took a substantial amount of time from LP ( 10 minutes ? ) so the move has really sped up inkup. You should be able to ssh into the machine, using vagrant/vagrant credentials, if you want to see what it is up to. Looking at top, and /var/log/syslog might give some hints? |
It's building :) |
And ends with:
|
"Ha, I think I know now why it only took 15 sec for you - you used the near-empty gitlab repo ;-)" You are right. I timed it again with correct URL, it is a more modest 3m55s now. Could try doing a make yourself inside the box? It seems something went wrong with the actual make:ing of the project, but at least lib2geom seems to have gone alright? Also, see my README.md for troubleshooting tips, to clean up the CMake files. |
Already working on it - running the build without all the options in the Vagrant file, though. Just Yeah, but now with a useful error message (sorry, right-click doesn't work in the VM, cannot copy-paste...): |
Btw. you must have awesome bandwidth :) |
Ah, just remembered something that might be happening here when you get weird "make fails". Increase the VM's RAM memory to like 6 GB. Since it is doing builds in paralell (make -j2) it consumes a lot of RAM. 3 GB might not make it. |
Ok, will try. |
Btw. the clean-cmake-files command doesn't work - it tells me that (I just delete the directory) |
Yeah, I would also just delete the build-inskscape folder and start over. Could you add an issue so that we do not forget to update the readme? Off to bed, thanks for all your testing and contribution! |
Good night - the build succeeded with more memory :) |
When README is updated, I'll add it back to the website :) |
Huh? I must have been totally confused. Now it got stuck again at 16%, and there is no Inkscape installed. The error must be with the Inkscape / libnrtype code. |
I think this build issue may be related. Might it be so that the devlib available inside the Lubuntu VM is dated? http://inkscape.13.x6.nabble.com/Alternative-glyphs-td4980002.html#a4980016 |
When I do an apt-cache policy on my 16.04-based machine, I get harfbuzz-dev 1.0.1, and Inkscape compiles. Shouldn't the if-else check for the harfbuzz version work just as well on 14.04?... Anyway, not exactly your issue... Unless you want to update the VM, too (then you could add more RAM, too - but I'm no longer sure it's needed.). I have timed the cloning now, too, on my desktop ;-) - result: |
OK, I don't quite understand how the dependency check works, is it a C-header or part of CMake scripts? Where would you make a change in the Inkscape project in order for upstream to fix this issue..? Or is it a consequence of some dependency add done in the provision script? Nice build time :) |
I can only give you the link to the file. I'm not a C++ person, and only know a little Python, all I can do is follow variable names around the code, by using search. (and it worked fine on Ubuntu 16.04 - but seemed to cause issues on the VM - the code is 6 days old, so it should have been available yesterday) |
Ok so one solution is to use a 16.04 base box instead of 14.04. There is probably some image available however it annoys me as it doesn't really explain the reason behind the error. We could check with Inkscape core devs on the irc channel I guess, if they can see anything obvious. |
Hi Olof,
can you let me know if you have the time to update the vagrant file?
This repo was linked from the Inkscape website at https://inkscape.org/en/develop/getting-started/ , and I had to take it out of it now, because of the git move. However, I would like to include it again, when the repo has been updated.
[Note to self: this is the text:
Building inside a Virtual Box VM
Possibly the simplest way to build Inkscape is using inkup, which provides you with a Vagrantfile capable of building a virtual machine, which build Inkscape from sources. It requires you to have VirtualBox and Vagrant installed on your machine.]
The text was updated successfully, but these errors were encountered: