Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize changes in "expected files" #16

Closed
greenrobot opened this issue Jul 13, 2020 · 1 comment · Fixed by #17
Closed

Minimize changes in "expected files" #16

greenrobot opened this issue Jul 13, 2020 · 1 comment · Fixed by #17
Assignees
@vaind

Comments

@greenrobot
Copy link
Member

To reduce the line count of changes in reviews, we should reduce the amount of tests with expected files.

Example: #12

Ideally, when there are changes to generated code, there should be a single file changed with minimal changes.

Side question: which integration tests have to be added to keep coverage up?
@greenrobot
Copy link
Member Author

Please start with low hanging fruits right away. Collect others with dependencies for later.

@vaind vaind mentioned this issue Jul 14, 2020
Merged
@vaind vaind closed this as completed in #17 Jul 16, 2020
dan-obx added a commit that referenced this issue Jul 16, 2024
@dan-obx
Merge branch '16-add-float-vectors' into 'dev'
5d45faf 
Resolve "Add float vectors"

Closes #16

See merge request objectbox/objectbox-generator!13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaind vaind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move to integration test objectbox/objectbox-generator
2 participants
@greenrobot @vaind