DataWriter doesn't remove unregistered instances #3684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrw972
force-pushed
the
unregister-instance
branch
from
cb779a9 to
c10703e
Compare
mitza-oci
requested changes
Aug 16, 2022
jrw972
force-pushed
the
unregister-instance
branch
from
c10703e to
fa655aa
Compare
mitza-oci
approved these changes
Aug 16, 2022
iguessthislldo
requested changes
Aug 16, 2022
|
Any explicit unit test possible for this? |
Problem ------- Entries in the maps of DataWriterImpl_t and WriteDataContainer correspond to instances. Unregistering an instance should remove from these maps to prevent a memory leak. Solution -------- Remove from these maps when instances are unregistered.
jrw972
force-pushed
the
unregister-instance
branch
from
fa655aa to
33092fe
Compare
Possible yes. However, I think it's going to take a serious refactoring of DataWriterImpl_T, DataWriterImpl, WriteDataContainer, and the associated transport framework to write it as a unit test and not an integration test. |
iguessthislldo
approved these changes
Aug 17, 2022
FooTest3_0 is not exactly a unit test, but it will provide coverage of these code paths |
mitza-oci
added a commit
that referenced
this pull request
Aug 22, 2022
DataWriter doesn't remove unregistered instances (cherry picked from commit 91fb793) # Conflicts: # dds/DCPS/DataWriterImpl_T.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Entries in the maps of DataWriterImpl_t and WriteDataContainer
correspond to instances. Unregistering an instance should remove from
these maps to prevent a memory leak.
Solution
Remove from these maps when instances are unregistered.