-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially document code #21
Conversation
@yegor256 take a look, please |
@mximp please, check this one |
@c71n93 Please check this blog post. I believe the whole OO design of the classes here should be redesigned. It's better to have "real world" entities (with names as meaningful nouns) which have clear interfaces. As an example of first step,
It's probably the subject of next PR |
@mximp I agree, that all code need redesign. But I think it should be done gradually, in the process of closing other issues. In this PR, I decided not to refactor the code, because it don't have enough tests. Without unit tests, something may break during refactoring. |
@mximp I have fixed all issues. Take a look, please. |
@mximp take a look please |
@yegor256 could you merge please? |
@rultor merge |
Closes #19. Documented only classes, which are involved in the generation of the Prolog file. Classes, that interact with
xmir
files, such asPrologInteractor
andFileTransformer
should be rewritten.