-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph Builder Refactoring #133
Conversation
@Graur could you review please? |
@c71n93 Github check failed. Is it ok? Or you need some extra time to fix it? |
@Graur The problem appears only in CI, locally it's Okay. I will try to fix it. |
@c71n93 Seems like this is the reason: Warning: Used undeclared dependencies found:
org.apache.commons:commons-lang3:jar:3.12.0:compile |
@Graur Thank you! I will fix it! |
@c71n93 Ok. The rest of the code is look good to me. If you fix this problem I can approve your changes. |
@Graur fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 It is better now, thanks!
@yegor256 please take a look |
@rultor merge |
Closes #119
Also:
PR-Codex overview
This PR focuses on improving the code readability and adding dependencies.
Detailed summary
Graph
class to clarify the type of objects it contains.commons-lang3
dependency to the project.DdrWorkflowTest
class.IGraphNode
class to use a different method for retrieving thename
property.AttributesSetter
class to use new utility methods for retrieving attribute content.BasicDecoratorsResolver
class to use new utility methods for retrieving attribute content.InnerPropagator
class to use the new utility methods for attribute retrieval.CondAttributesSetter
class to use the new utility methods for attribute retrieval.