Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

fixed failed build on Windows #54

Merged
merged 12 commits into from
Mar 15, 2023
Merged

Conversation

Graur
Copy link
Contributor

@Graur Graur commented Mar 14, 2023

What's done:

  • changed implementation of uname object from EO to Java. Due to text.contains and text.low-cased couldn't work with a long string
  • added todo

@Graur Graur changed the title test fixed failed build on Windows Mar 15, 2023
@Graur Graur marked this pull request as ready for review March 15, 2023 09:23
@Graur
Copy link
Contributor Author

Graur commented Mar 15, 2023

@yegor256 uname object is the reason of the pending Windows checks in eo-runtime. I tried to redo it somehow, but didn't reach a success. Only this solution with Java implementation works for me. Can you please take a look and give some feedback?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Mar 15, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit dfc684b into objectionary:master Mar 15, 2023
@rultor
Copy link
Contributor

rultor commented Mar 15, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 5min)

@Graur Graur deleted the new_release branch March 15, 2023 14:14
@Graur Graur mentioned this pull request Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants