#1077 limit possible class names #1138
Conversation
|
@yegor256 please review |
|
@OlesiaSub pls, review |
|
@OlesiaSub please check |
| <xsl:variable name="pre" select="concat($p, eo:clean($c))"/> | ||
| <xsl:choose> | ||
| <xsl:when test="string-length($pre)>250"> | ||
| <xsl:value-of select="concat(substring($pre, 1, 25), $alt)"/> |
There was a problem hiding this comment.
@mximp what about possible conflicts between two long class names? If you just cut them, you will have them conflicted for sure.
There was a problem hiding this comment.
@yegor256 that's why I pass $alt which is combination of line & position. Within a file it should be unique postfix.
|
@mximp I think it's a weak solution: just cutting the name to fit into the maximum size. |
| <xsl:variable name="pre" select="concat($p, eo:clean($c))"/> | ||
| <xsl:choose> | ||
| <xsl:when test="string-length($pre)>250"> | ||
| <xsl:value-of select="concat(substring($pre, 1, 25), $alt)"/> |
There was a problem hiding this comment.
Agreed, maybe you could introduce another naming convention for long class names to avoid possible collisions? For instance, if class name is too long you could just hash it somehow or smth like that.
There was a problem hiding this comment.
@OlesiaSub @yegor256 Hashing would be ideal solution. I tried to find relevant functions but had no luck
Do you have an idea how to create it in XSL language?
There was a problem hiding this comment.
@mximp take a look https://stackoverflow.com/questions/62388458/create-an-md5-encryption-function-using-pure-xsl, maybe it will be helpful..
But actually, if hashing is impossible/too complicated in xsl, can't you just create some names using XSL and then hash the long ones using non-xsl methods? (I'm not sure how this translator to java works, so maybe this idea is useless or impossible to implement too :) )
There was a problem hiding this comment.
@OlesiaSub thanks for the hint.. That's exactly what I'm talking about: there is no simple and elegant solution to implement it. The suggestion by the link is to use integration with Java which sounds overly complex.
Actually combination of file name, line and position of an object will give unique short name.
There was a problem hiding this comment.
@mximp ok got it. can I ask Yegor to merge it if the Codacy check doesn't pass though?
There was a problem hiding this comment.
@OlesiaSub I believe we ignore Codacy checks.
@yegor256 do you agree with uniqueness by name+line+position?
There was a problem hiding this comment.
@mximp @OlesiaSub it's possible to marry Java and XSL. You can implement a Shift in Java, where you will inject MD5 hashes into the right places. See, how it works here: https://github.com/polystat/far/blob/master/src/main/java/org/polystat/far/FaR.java#L110-L134
There was a problem hiding this comment.
@yegor256 I've just checked suggested example. This implies that we will need to make transformation after all Java code is created. And we will just do text replacement.
I still suggest initial solution with line/position. It guaranties uniqueness across the file and also preserves some meaning of the name. We also keep original object name in @XmirObject annotation.
What do you think?
There was a problem hiding this comment.
@mximp I don't mind at all, as long as names are unique
There was a problem hiding this comment.
@yegor256 then please merge
|
@rultor merge |
#1077 Trim Java class names