Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#2352): Remove ChCompound #2387

Merged
merged 2 commits into from
Aug 14, 2023
Merged

feat(#2352): Remove ChCompound #2387

merged 2 commits into from
Aug 14, 2023

Conversation

volodya-lombrozo
Copy link
Member

@volodya-lombrozo volodya-lombrozo commented Aug 14, 2023 •
edited by pr-codex bot
Loading

Remove ChCompound and ChCompoundTest since they aren't used.

Closes: #2352

PR-Codex overview

Detailed summary

  • Deleted ChCompound.java and ChCompoundTest.java files.
  • Replaced ChCompound import with ChRemote import.
  • Updated the argument passed to ChRemote constructor in the pullsFromProbes method.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo
Copy link
Member Author

@maxonfjvipon Could you take a look, please?

maxonfjvipon
maxonfjvipon approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo LGTM! Thanks

@volodya-lombrozo
Copy link
Member Author

@yegor256 Could you merge that changes, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Aug 14, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1d2d786 into objectionary:master Aug 14, 2023
10 checks passed
@rultor
Copy link
Contributor

rultor commented Aug 14, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 11min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChCompound.java:33-35: Do we really need the class? It...
4 participants
@volodya-lombrozo @yegor256 @rultor @maxonfjvipon