Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2586 sodg mojo test #2614

Merged
merged 8 commits into from
Nov 23, 2023
Merged

2586 sodg mojo test #2614

merged 8 commits into from
Nov 23, 2023

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Nov 21, 2023 •
edited
Loading

Closes #2586, #2562

@levBagryansky
Copy link
Member Author

@maxonfjvipon please check

maxonfjvipon
maxonfjvipon approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky LGTM! Thanks

@levBagryansky
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Nov 23, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4e2582b into objectionary:master Nov 23, 2023
11 checks passed
@rultor
Copy link
Contributor

rultor commented Nov 23, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 23min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SodgMojoTest.java:62-64: Enable the tests: Some tests in...
4 participants
@levBagryansky @yegor256 @rultor @maxonfjvipon