Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#2665): application with digits #2669

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Dec 4, 2023

Closes: #2665


PR-Codex overview

Focus of this PR:

This PR focuses on adding support for integer bindings in the EO language parser and making related changes in the XSL transformation.

Detailed summary:

  • Added support for integer bindings in the EO language parser.
  • Updated the XSL transformation to handle integer bindings.
  • Added a TODO comment to check negative integer bindings via XSL.
  • Updated the Maven plugin resources to include necessary XSL files for integer bindings.
  • Added test cases for integer bindings in the Maven plugin.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon
Copy link
Member Author

@yegor256 please have a look

@yegor256
Copy link
Member

yegor256 commented Dec 4, 2023

@rultor merge

@rultor
Copy link
Contributor

rultor commented Dec 4, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 881ed60 into objectionary:master Dec 4, 2023
12 checks passed
@rultor
Copy link
Contributor

rultor commented Dec 4, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 19min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application with bindings by digits
3 participants