some tests enabled #2711
some tests enabled #2711
Conversation
|
@yegor256 the original idea of |
|
@maxonfjvipon got it, I'll revert it |
|
@maxonfjvipon for some reason this change breaks the build. I can't understand why this happens... Any ideas? |
|
@yegor256 let me check |
| <goals> | ||
| <goal>register</goal> | ||
| <goal>assemble</goal> | ||
| <goal>transpile</goal> |
There was a problem hiding this comment.
@yegor256 you forgot verify here
There was a problem hiding this comment.
@maxonfjvipon yes, this is true, but the problem is in the SnippetTestCase -- they fail
There was a problem hiding this comment.
@maxonfjvipon also, the absence of verify here should not be the problem -- the code that is not verified still can be traspiled, right? The verify step is optional. If the user is sure that all XMIR files are valid, he may skip the verify step. Am I wrong?
There was a problem hiding this comment.
@yegor256 transpile mojo expects xmir files in 4-verified directory, which is absent if verify step was skipped. Actually it's a bug because files are not changed after verification so there's no point to rewrite them one more time
|
@yegor256 see above |
|
@maxonfjvipon please, review this one |
| out: | ||
| - ".*greater.*" | ||
| args: [ "main", "17" ] | ||
| file: org/eolang/snippets/ifthenelse.eo | ||
| args: [ "org.eolang.snippets.ifthenelse", "17" ] |
There was a problem hiding this comment.
@yegor256 maybe it's not really part of you task, but what's the point passing "17" here, if it isn't used?
There was a problem hiding this comment.
@maxonfjvipon fixed in 6c24bae
|
@rultor merge |
Closes #2660
PR-Codex overview
Detailed summary
This PR focuses on adding new EO snippets and integration tests, updating Maven configuration, and improving documentation.