Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2890 parameter of cage stack #2892

Merged
merged 25 commits into from
Feb 27, 2024
Merged

2890 parameter of cage stack #2892

merged 25 commits into from
Feb 27, 2024

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Feb 22, 2024 •
edited by pr-codex bot

Closes #2890
Made the depth configurable via properties.

PR-Codex overview

This PR updates PhTracedEnclosure to handle cage recursion depth and fixes a flaky test in VerifyMojoTest.

Detailed summary

  • Added MAX_CAGE_RECURSION_DEPTH_PROPERTY_NAME in PhTracedEnclosure
  • Updated constructor and methods in PhTracedEnclosure for recursion depth handling
  • Fixed a flaky test in VerifyMojoTest and provided detailed comments

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please take a look

@levBagryansky
Copy link
Member Author

@maxonfjvipon please take a look

maxonfjvipon
maxonfjvipon suggested changes Feb 26, 2024
View reviewed changes
eo-maven-plugin/src/test/java/org/eolang/maven/VerifyMojoTest.java Outdated Show resolved Hide resolved
eo-runtime/src/main/java/org/eolang/PhTracedEnclosure.java Outdated Show resolved Hide resolved
eo-runtime/src/main/java/org/eolang/PhTracedEnclosure.java Outdated Show resolved Hide resolved
eo-runtime/src/main/java/org/eolang/PhTracedEnclosure.java Outdated Show resolved Hide resolved
eo-runtime/src/test/java/EOorg/EOeolang/EOcageTest.java Outdated Show resolved Hide resolved
eo-runtime/src/test/java/EOorg/EOeolang/EOcageTest.java Outdated Show resolved Hide resolved
eo-runtime/src/test/java/EOorg/EOeolang/EOcageTest.java Outdated Show resolved Hide resolved
eo-runtime/src/test/java/EOorg/EOeolang/EOcageTest.java Outdated Show resolved Hide resolved
@maxonfjvipon
Copy link
Member

@levBagryansky could you please explain how I as end-user of eo-runtime maven plugin can set this cages recursion depth?

@levBagryansky
Copy link
Member Author

@maxonfjvipon you can set property via -D:
java -DEO_MAX_CAGE_RECURSION_DEPTH=10000 <our jar>
or export EO_MAX_CAGE_RECURSION_DEPTH=10000 in terminal

maxonfjvipon
maxonfjvipon approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky LGTM! Thanks

@maxonfjvipon maxonfjvipon mentioned this pull request Feb 26, 2024
Open
@levBagryansky
Copy link
Member Author

@yegor256 please check

1 similar comment
@levBagryansky
Copy link
Member Author

@yegor256 please check

@yegor256 yegor256 merged commit 28cd918 into objectionary:master Feb 27, 2024
15 checks passed
@levBagryansky levBagryansky deleted the 2890_parameter-of-cage-stack branch February 27, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PhTracedEnclosure.java:33-35: Add a new parameter of...
3 participants
@levBagryansky @maxonfjvipon @yegor256