-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3058: Fixed access modifier in EOorg/EOeolang/ #3103
#3058: Fixed access modifier in EOorg/EOeolang/ #3103
Conversation
@maxonfjvipon Please review |
@yegor256 please check |
@levBagryansky just setting it to |
@levBagryansky isn't it easier to use Reflection for this, in runtime? When unit tests in the eo-runtime package are executed, all Java classes are parsed and available in classpath. Just search for all classes in the package and check their access modifiers. |
@yegor256 I tried to use
Looks like the main issue is how to use foreign dependencies in |
@levBagryansky that's what I'm saying. You don't need Groovy for this task. Just create a normal unit test in the eo-runtime: it should scan the classpath, find all classes in the |
@yegor256 please check. For some reason reflections did not counted all classes, so I used guava here. Here we check 827 classes |
@yegor256 please check |
@rultor merge |
Closes #3058
PR-Codex overview
This PR adds a test to ensure all EO.. classes are public in the EOorg.EOeolang package.
Detailed summary
EoClassesArePublicTest
to check public access for EO.. classes