Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): multiplatform console read #3335

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Aug 14, 2024

Ref: #3251


PR-Codex overview

The focus of this PR is to enhance the Wincon and CStdLib interfaces in the EOsys package, update the Win32 object in sys package, and introduce a new ReadFileFuncCall for Win32.

Detailed summary

  • Updated Wincon interface with constants
  • Added new constants to CStdLib interface
  • Enhanced Win32 object in sys package
  • Introduced ReadFileFuncCall for Win32
  • Refactored console object in io package

The following files were skipped due to too many changes: eo-runtime/src/main/eo/org/eolang/io/console.eo, eo-runtime/src/test/java/EOorg/EOeolang/EOio/InputOutputTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@yegor256
Copy link
Member

@rultor merge

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rultor
Copy link
Contributor

rultor commented Aug 15, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Aug 15, 2024

@rultor merge

@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 19min)

[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 s -- in EOorg.EOeolang.EOpositive_infinity_div_negative_intTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_not_gte_nanTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 s -- in EOorg.EOeolang.EOpositive_infinity_not_gte_nanTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_not_eq_negative_infinityTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 s -- in EOorg.EOeolang.EOpositive_infinity_not_eq_negative_infinityTest
[INFO] Running EOorg.EOeolang.EOtxt.EOformats_all_objectsTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.429 s -- in EOorg.EOeolang.EOtxt.EOformats_all_objectsTest
[INFO] Running EOorg.EOeolang.EOmalloc_writes_and_readsTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.250 s -- in EOorg.EOeolang.EOstructs.EOlist_withoutiTest
[INFO] Running EOorg.EOeolang.EOrust_long_variableTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.034 s -- in EOorg.EOeolang.EOrust_long_variableTest
[INFO] Running EOorg.EOeolang.EOrust_errorTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 s -- in EOorg.EOeolang.EOrust_errorTest
[INFO] Running EOorg.EOeolang.EOtxt.EOtext_trimmed_one_space_rightTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.177 s -- in EOorg.EOeolang.EOtxt.EOtext_trimmed_one_space_rightTest
[INFO] Running org.eolang.ExInterruptedTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s -- in org.eolang.ExInterruptedTest
[INFO] Running EOorg.EOeolang.EOand_with_zeroTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 s -- in EOorg.EOeolang.EOand_with_zeroTest
[INFO] Running EOorg.EOeolang.EOstructs.EOthrows_on_range_of_not_intsTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.139 s -- in EOorg.EOeolang.EOstructs.EOthrows_on_range_of_not_intsTest
[INFO] Running EOorg.EOeolang.EOfs.EOtakes_valid_basenameTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.466 s -- in EOorg.EOeolang.EOmalloc_writes_and_readsTest
[INFO] Running org.eolang.PhLocatedTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s -- in org.eolang.PhLocatedTest
[INFO] Running EOorg.EOeolang.EOtxt.EOtext_trimmed_many_spacesTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.362 s -- in EOorg.EOeolang.EOtxt.EOtext_trimmed_many_spacesTest
[INFO] Running EOorg.EOeolang.EOturns_bytes_into_a_stringTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s -- in EOorg.EOeolang.EOturns_bytes_into_a_stringTest
[INFO] Running EOorg.EOeolang.EOvery_long_seqTest
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.323 s -- in EOorg.EOeolang.EOfs.EOtakes_valid_basenameTest
[INFO] Running EOorg.EOeolang.EOint_less_trueTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 s -- in EOorg.EOeolang.EOint_less_trueTest
[INFO] Running EOorg.EOeolang.EOor_neg_bytes_with_oneTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 s -- in EOorg.EOeolang.EOor_neg_bytes_with_oneTest
[INFO] Running EOorg.EOeolang.EOfs.EOnormalizes_win32_path_down_to_drive_with_separatorTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.225 s -- in org.eolang.MainTest
[INFO] Running EOorg.EOeolang.EOfs.EOappending_data_to_fileTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.952 s -- in EOorg.EOeolang.EOfs.EOnormalizes_win32_path_down_to_drive_with_separatorTest
[INFO] Running EOorg.EOeolang.EOcorrectly_handles_same_name_attrs_simplifiedTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.020 s -- in EOorg.EOeolang.EOcorrectly_handles_same_name_attrs_simplifiedTest
[INFO] Running EOorg.EOeolang.EOtxt.EOthrows_on_sprintf_with_arguments_that_does_not_matchTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.058 s -- in EOorg.EOeolang.EOtxt.EOthrows_on_sprintf_with_arguments_that_does_not_matchTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_div_positive_intTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.031 s -- in EOorg.EOeolang.EOpositive_infinity_div_positive_intTest
[INFO] Running EOorg.EOeolang.EOgoto_jumps_forwardTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.189 s -- in EOorg.EOeolang.EOfs.EOappending_data_to_fileTest
[INFO] Running EOorg.EOeolang.EOtxt.EOindex_of_non_existed_substring_with_same_lengthTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.095 s -- in EOorg.EOeolang.EOtxt.EOindex_of_non_existed_substring_with_same_lengthTest
[INFO] Running EOorg.EOeolang.EOstructs.EOrange_of_negative_ints_works_as_wellTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.144 s -- in EOorg.EOeolang.EOgoto_jumps_forwardTest
[INFO] Running EOorg.EOeolang.EOtxt.EOsscanf_with_complex_intTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 s -- in EOorg.EOeolang.EOtxt.EOsscanf_with_complex_intTest
[INFO] Running EOorg.EOeolang.EOpositive_infinity_as_bytes_is_validTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 s -- in EOorg.EOeolang.EOpositive_infinity_as_bytes_is_validTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.313 s -- in EOorg.EOeolang.EOstructs.EOrange_of_negative_ints_works_as_wellTest
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.50 s -- in EOorg.EOeolang.EOvery_long_seqTest
/home/r/script.sh: line 9:  1684 Killed                  mvn clean install -Pqulice --errors -Dstyle.color=never
container 68e3f41adaa1a17a4327493ffacbaa33391718bcc683f8f050674632bd3a6d1d is dead
Thu Aug 15 07:11:20 UTC 2024

@maxonfjvipon
Copy link
Member Author

@yegor256 the process was killed(

@yegor256 yegor256 merged commit c306622 into objectionary:master Aug 15, 2024
22 checks passed
@0crat
Copy link

0crat commented Aug 15, 2024

@yegor256 Hey there, code review superstar! 🌟 You've just racked up a sweet 35 points for your latest review. Here's the breakdown: 15 points for being an awesome reviewer, plus a whopping 30 for tackling those 1,750 hits-of-code (that's some serious dedication!). We had to dock 10 points because there were only 3 comments (remember, we're aiming for at least 6 next time), but don't let that discourage you. Your total balance is now sitting pretty at +213 – keep up the great work!

@0crat
Copy link

0crat commented Aug 15, 2024

@maxonfjvipon Hey there! 👋 Great job on your contribution! You've earned +5 points, which is the minimum reward we give. Here's the breakdown: +20 base points, -7 for exceeding 200 hits-of-code, -15 for surpassing 800 hits-of-code (wow, 1750!), and -5 for having only 4 comments. We love to see big contributions, but remember that quality matters too. Next time, try to keep it under 800 hits-of-code and encourage more review comments. Your balance is now +239. Keep up the good work and happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants