-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3251): multiplatform console read #3335
feat(#3251): multiplatform console read #3335
Conversation
@rultor merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@maxonfjvipon @yegor256 Oops, I failed. You can see the full log here (spent 19min)
|
@yegor256 the process was killed( |
@yegor256 Hey there, code review superstar! 🌟 You've just racked up a sweet 35 points for your latest review. Here's the breakdown: 15 points for being an awesome reviewer, plus a whopping 30 for tackling those 1,750 hits-of-code (that's some serious dedication!). We had to dock 10 points because there were only 3 comments (remember, we're aiming for at least 6 next time), but don't let that discourage you. Your total balance is now sitting pretty at +213 – keep up the great work! |
@maxonfjvipon Hey there! 👋 Great job on your contribution! You've earned +5 points, which is the minimum reward we give. Here's the breakdown: +20 base points, -7 for exceeding 200 hits-of-code, -15 for surpassing 800 hits-of-code (wow, 1750!), and -5 for having only 4 comments. We love to see big contributions, but remember that quality matters too. Next time, try to keep it under 800 hits-of-code and encourage more review comments. Your balance is now +239. Keep up the good work and happy coding! 🚀 |
Ref: #3251
PR-Codex overview
The focus of this PR is to enhance the Wincon and CStdLib interfaces in the EOsys package, update the Win32 object in sys package, and introduce a new ReadFileFuncCall for Win32.
Detailed summary