Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3251): introduced real number from eo-math #3367

Merged

Conversation

maxonfjvipon
Copy link
Member

@maxonfjvipon maxonfjvipon commented Sep 9, 2024

Ref: #3251


PR-Codex overview

This PR adds new mathematical functions to the EOreal class and updates the license information in multiple files.

Detailed summary

  • Added EOreal$EOpow, EOreal$EOasin, EOreal$EOacos, EOreal$EOln, and EOreal$EOsqrt classes to EOmath
  • Updated license information in multiple files
  • Added alias and architect information in real.eo

The following files were skipped due to too many changes: eo-runtime/src/main/eo/org/eolang/math/real.eo, eo-runtime/src/test/eo/org/eolang/math/real-tests.eo

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@maxonfjvipon maxonfjvipon changed the title feat(#3251): introduced real number from eo-math feat(#3251): introduced real number from eo-math Sep 9, 2024
@maxonfjvipon
Copy link
Member Author

@yegor256 please check

Copy link
Member

@yegor256 yegor256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxonfjvipon you forgot to rename the .eo file

@maxonfjvipon
Copy link
Member Author

@yegor256 please check one more time

@yegor256
Copy link
Member

yegor256 commented Sep 9, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented Sep 9, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit f7b8584 into objectionary:master Sep 9, 2024
21 checks passed
@rultor
Copy link
Contributor

rultor commented Sep 9, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 29min)

@0crat
Copy link

0crat commented Sep 9, 2024

@maxonfjvipon Great job on your contribution! 🌟 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we appreciate your effort. Your balance is now +35. Keep the contributions coming and remember to focus on quality as you code. We're excited to see your next submission!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants