#82 remove transpiled xmirs before dataize #83

mximp · 2022-10-14T14:19:31Z

#82 remove transpiled xmirs before dataize

mximp · 2022-10-14T14:20:00Z

yegor256 · 2022-10-14T17:18:50Z

@mximp I think this has to be done by our maven plugin, in much smarter way. We track transpiled objects in TranspileMojo and delete unnecessary. Don't we?

mximp · 2022-10-17T09:36:43Z

@yegor256 eoc in this case deletes generated-sources without touching transpile.csv and/or 06-transpiled/ content which seems inconsistent (it removes partial result of transpilation). So tried to add this consistency by removing 06-transpiled\ along with generated-sources\.
From TranspileMojo point of view we could add additional check for presence of .java file within generated-sources folder.

yegor256 · 2022-10-17T11:17:56Z

@mximp maybe deleting generated-sources/ is the bug? I don't like this behavior of eoc, it's intrusive. It should just call maven plugin and let plugin decide what needs to be deleted and when. WDYT?

mximp · 2022-10-17T11:45:08Z

@yegor256 First I thought that deleting generated-sources was done for proper compilation in eoc. But now I cannot see a reason for that. The deletion was added by #20. There is no explanation for that.
I made some experiments not deleting the folder - and it looks fine. Even fixes the issue.
Let's remove it.

mximp · 2022-10-17T11:48:05Z

@yegor256 please review

yegor256 · 2022-10-17T12:54:48Z

@rultor merge

rultor · 2022-10-17T12:56:01Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-10-17T13:04:36Z

@rultor merge

@mximp @yegor256 Oops, I failed. You can see the full log here (spent 8min)

[INFO] 0 attributes loaded from 37 stream(s) in 132ms, 47 saved, 431 ignored: []
[INFO] Parsed 1 .eo sources to XMIRs
[WARNING] XSL transformation 'not-empty-atoms' took too long 466ms (over 100ms)
[WARNING] XSL transformation 'not-empty-atoms' took too long 529ms (over 100ms)
[WARNING] XSL transformation 'broken-aliases' took too long 105ms (over 100ms)
[INFO] Optimized 1 out of 1 XMIR program(s)
[INFO] No foreign objects discovered in 1 programs
[INFO] The directory is absent, nothing to place: ./home/r/repo/temp/test-gmi/simple/target/06-resolve
[INFO] Assemble cycle #1 (eo:1/xmir:0/xmir2:0/discovered:0 -> eo:1/xmir:1/xmir2:1/discovered:1), took 4s
[INFO] No .eo sources parsed to XMIRs
[INFO] Nothing to discover, all programs checked already
[INFO] The directory is absent, nothing to place: ./home/r/repo/temp/test-gmi/simple/target/06-resolve
[INFO] Assemble cycle #2 (eo:1/xmir:1/xmir2:1/discovered:1 -> eo:1/xmir:1/xmir2:1/discovered:1), took 1s
[INFO] 2 assemble cycle(s) produced some new object(s): eo:1/xmir:1/xmir2:1/discovered:1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.297 s
[INFO] Finished at: 2022-10-17T13:01:53Z
[INFO] ------------------------------------------------------------------------
\u001b[37mEO program assembled in /home/r/repo/temp/test-gmi/simple/target\u001b[39m
\u001b[37mEO version is 0.28.10\u001b[39m
\u001b[90m+ /home/r/repo/mvnw/mvnw eo:gmi -Deo.version=0.28.10 -Deo.targetDir=/home/r/repo/temp/test-gmi/simple/target -Deo.gmiIncludes=simple -Deo.generateGmiXmlFiles -Deo.generateXemblyFiles -Deo.generateGraphFiles -Deo.generateDotFiles --errors --batch-mode --update-snapshots --fail-fast\u001b[39m
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------------< org.eolang:eoc >---------------------------
[INFO] Building eoc 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- eo-maven-plugin:0.28.10:gmi (default-cli) @ eoc ---
[WARNING] XSL transformation 'remove-leveled' took too long 571ms (over 100ms)
[INFO] GMI for simple saved to ./home/r/repo/temp/test-gmi/simple/target/gmi/simple.gmi (2 instructions)
[INFO] Converted 1 .xmir to GMIs, saved to ./home/r/repo/temp/test-gmi/simple/target/gmi, 2 instructions
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.328 s
[INFO] Finished at: 2022-10-17T13:01:56Z
[INFO] ------------------------------------------------------------------------
\u001b[37mGMI files generated in /home/r/repo/temp/test-gmi/simple/target\u001b[39m
\u001b[0m
      \u001b[32m+ expected\u001b[0m \u001b[31m- actual\u001b[0m

      \u001b[31m-false\u001b[0m
      \u001b[32m+true\u001b[0m
      \u001b[0m\u001b[90m
      at /home/r/repo/test/helpers.js:61:5
      at Array.forEach (<anonymous>)
      at assertFilesExist (test/helpers.js:59:9)
      at Context.<anonymous> (test/commands/test_gmi.js:44:5)
      at processImmediate (node:internal/timers:466:21)
\u001b[0m


Warning:  Use --force to continue.

Aborted due to warnings.
container 0e0f444706f935ddccb49294339b4ff9f07a4768379c630638970eccff8dedbe is dead
Mon 17 Oct 2022 03:04:30 PM CEST

mximp · 2022-10-19T08:21:28Z

@yegor256 should we try again?

yegor256 · 2022-10-19T11:59:56Z

@rultor merge

rultor · 2022-10-19T12:01:32Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-10-19T12:08:48Z

@rultor merge

@mximp @yegor256 Oops, I failed. You can see the full log here (spent 7min)

[INFO] Parsed 1 .eo sources to XMIRs
[WARNING] XSL transformation 'not-empty-atoms' took too long 469ms (over 100ms)
[WARNING] XSL transformation 'not-empty-atoms' took too long 529ms (over 100ms)
[WARNING] XSL transformation 'broken-aliases' took too long 103ms (over 100ms)
[WARNING] XSL transformation 'broken-aliases' took too long 124ms (over 100ms)
[INFO] Optimized 1 out of 1 XMIR program(s)
[INFO] No foreign objects discovered in 1 programs
[INFO] The directory is absent, nothing to place: ./home/r/repo/temp/test-gmi/simple/target/06-resolve
[INFO] Assemble cycle #1 (eo:1/xmir:0/xmir2:0/discovered:0 -> eo:1/xmir:1/xmir2:1/discovered:1), took 4s
[INFO] No .eo sources parsed to XMIRs
[INFO] Nothing to discover, all programs checked already
[INFO] The directory is absent, nothing to place: ./home/r/repo/temp/test-gmi/simple/target/06-resolve
[INFO] Assemble cycle #2 (eo:1/xmir:1/xmir2:1/discovered:1 -> eo:1/xmir:1/xmir2:1/discovered:1), took 1s
[INFO] 2 assemble cycle(s) produced some new object(s): eo:1/xmir:1/xmir2:1/discovered:1
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.306 s
[INFO] Finished at: 2022-10-19T12:06:12Z
[INFO] ------------------------------------------------------------------------
\u001b[37mEO program assembled in /home/r/repo/temp/test-gmi/simple/target\u001b[39m
\u001b[37mEO version is 0.28.10\u001b[39m
\u001b[90m+ /home/r/repo/mvnw/mvnw eo:gmi -Deo.version=0.28.10 -Deo.targetDir=/home/r/repo/temp/test-gmi/simple/target -Deo.gmiIncludes=simple -Deo.generateGmiXmlFiles -Deo.generateXemblyFiles -Deo.generateGraphFiles -Deo.generateDotFiles --errors --batch-mode --update-snapshots --fail-fast\u001b[39m
[INFO] Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------------< org.eolang:eoc >---------------------------
[INFO] Building eoc 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- eo-maven-plugin:0.28.10:gmi (default-cli) @ eoc ---
[WARNING] XSL transformation 'remove-leveled' took too long 576ms (over 100ms)
[INFO] GMI for simple saved to ./home/r/repo/temp/test-gmi/simple/target/gmi/simple.gmi (2 instructions)
[INFO] Converted 1 .xmir to GMIs, saved to ./home/r/repo/temp/test-gmi/simple/target/gmi, 2 instructions
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.344 s
[INFO] Finished at: 2022-10-19T12:06:16Z
[INFO] ------------------------------------------------------------------------
\u001b[37mGMI files generated in /home/r/repo/temp/test-gmi/simple/target\u001b[39m
\u001b[0m
      \u001b[32m+ expected\u001b[0m \u001b[31m- actual\u001b[0m

      \u001b[31m-false\u001b[0m
      \u001b[32m+true\u001b[0m
      \u001b[0m\u001b[90m
      at /home/r/repo/test/helpers.js:61:5
      at Array.forEach (<anonymous>)
      at assertFilesExist (test/helpers.js:59:9)
      at Context.<anonymous> (test/commands/test_gmi.js:44:5)
      at processImmediate (node:internal/timers:466:21)
\u001b[0m


Warning:  Use --force to continue.

Aborted due to warnings.
container ccd5008c2d76c18ced5a4b5cdb7fc4d05378826a60153ccb23c34ff8f68c1983 is dead
Wed 19 Oct 2022 02:08:42 PM CEST

volodya-lombrozo · 2022-10-20T08:59:18Z

@yegor256 I've fixed the pipeline exception in that PR. Can you run merge again?

yegor256 · 2022-10-20T09:01:04Z

@rultor merge

rultor · 2022-10-20T09:01:41Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

yegor256 · 2022-10-20T09:02:44Z

@volodya-lombrozo the build is not stable due to not-long-enough timeouts. However, making them larger will be a lousy solution. Maybe you can find a better one.

rultor · 2022-10-20T09:09:10Z

@rultor merge

@mximp @yegor256 Oops, I failed. You can see the full log here (spent 7min)

\u001b[0m  dataize\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m runs a single executable .JAR and dataizes an object\u001b[0m\u001b[31m (61422ms)\u001b[0m

\u001b[0m  foreign\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m inspects foreign objects and prints a report\u001b[0m\u001b[31m (37022ms)\u001b[0m

\u001b[0m  gmi\u001b[0m
ANTLR Tool version 4.10.1 used for code generation does not match the current runtime version 4.11.1
ANTLR Runtime version 4.10.1 used for parser compilation does not match the current runtime version 4.11.1
ANTLR Tool version 4.10.1 used for code generation does not match the current runtime version 4.11.1
ANTLR Runtime version 4.10.1 used for parser compilation does not match the current runtime version 4.11.1
  \u001b[32m  ✓\u001b[0m\u001b[90m generates GMI files for a simple .EO program\u001b[0m\u001b[31m (18619ms)\u001b[0m

\u001b[0m  link\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m compiles a simple .EO program into an executable .JAR\u001b[0m\u001b[31m (48867ms)\u001b[0m

\u001b[0m  register\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m registers a simple .EO program\u001b[0m\u001b[31m (2464ms)\u001b[0m

\u001b[0m  test\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m executes a single unit test\u001b[0m\u001b[31m (71449ms)\u001b[0m

\u001b[0m  transpile\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m transpiles a simple .EO program\u001b[0m\u001b[31m (13306ms)\u001b[0m

\u001b[0m  eoc\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m prints its own version\u001b[0m\u001b[31m (91ms)\u001b[0m
  \u001b[32m  ✓\u001b[0m\u001b[90m prints help screen\u001b[0m\u001b[31m (91ms)\u001b[0m

\u001b[0m  mvnw\u001b[0m
+ /home/r/repo/mvnw/mvnw --version --errors --batch-mode --update-snapshots --fail-fast
\u001b[0m\u001b[0mApache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /home/r/.m2/wrapper/dists/apache-maven-3.8.4-bin/66e9f8f4/apache-maven-3.8.4
Java version: 11.0.16, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-105-generic", arch: "amd64", family: "unix"
\u001b[0m\u001b[0m+ /home/r/repo/mvnw/mvnw --version --errors --batch-mode --update-snapshots --fail-fast
\u001b[0m\u001b[0mApache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: /home/r/.m2/wrapper/dists/apache-maven-3.8.4-bin/66e9f8f4/apache-maven-3.8.4
Java version: 11.0.16, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.4.0-105-generic", arch: "amd64", family: "unix"
\u001b[0m\u001b[0m  \u001b[32m  ✓\u001b[0m\u001b[90m prints Maven own version\u001b[0m\u001b[31m (490ms)\u001b[0m


\u001b[92m \u001b[0m\u001b[32m 15 passing\u001b[0m\u001b[90m (6m)\u001b[0m


Running "eslint:target" (eslint) task

/home/r/repo/src/commands/transpile.js
  26:7  error  'fs' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

Warning: Task "eslint:target" failed. Use --force to continue.

Aborted due to warnings.
container 62ff396d3f9702238b3468b1333b0cbf3a8994ac31d2802eff74e04db0c0d678 is dead
Thu 20 Oct 2022 11:09:04 AM CEST

volodya-lombrozo · 2022-10-20T09:18:24Z

@volodya-lombrozo the build is not stable due to not-long-enough timeouts. However, making them larger will be a lousy solution. Maybe you can find a better one.

I can try, why not, but it's better to introduce a separate issue for that and add more context information about the problem.

yegor256 · 2022-10-20T09:20:49Z

@mximp try to run npm eslint

mximp · 2022-10-20T09:53:38Z

@yegor256 there was one error. Now fixed. Please merge.

mximp · 2022-10-24T07:43:19Z

@yegor256 reminder

yegor256 · 2022-10-24T07:51:23Z

@rultor merge

rultor · 2022-10-24T07:52:29Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-10-24T07:59:59Z

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 7min)

#82 remove transpiled xmirs before dataize

f1aa452

mximp requested a review from yegor256 October 14, 2022 14:20

#82 stop cleaning generated-sources before run

48bfec8

#82 eslint error fix

8723e17

rultor merged commit 1f0f764 into objectionary:master Oct 24, 2022

volodya-lombrozo mentioned this pull request Oct 24, 2022

Build is not stable due to not-long-enough timeouts #87

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#82 remove transpiled xmirs before dataize #83

#82 remove transpiled xmirs before dataize #83

mximp commented Oct 14, 2022

mximp commented Oct 14, 2022

yegor256 commented Oct 14, 2022

mximp commented Oct 17, 2022 •

edited

Loading

yegor256 commented Oct 17, 2022

mximp commented Oct 17, 2022

mximp commented Oct 17, 2022

yegor256 commented Oct 17, 2022

rultor commented Oct 17, 2022

rultor commented Oct 17, 2022

mximp commented Oct 19, 2022

yegor256 commented Oct 19, 2022

rultor commented Oct 19, 2022

rultor commented Oct 19, 2022

volodya-lombrozo commented Oct 20, 2022

yegor256 commented Oct 20, 2022

rultor commented Oct 20, 2022

yegor256 commented Oct 20, 2022

rultor commented Oct 20, 2022

volodya-lombrozo commented Oct 20, 2022

yegor256 commented Oct 20, 2022

mximp commented Oct 20, 2022

mximp commented Oct 24, 2022

yegor256 commented Oct 24, 2022

rultor commented Oct 24, 2022

rultor commented Oct 24, 2022

#82 remove transpiled xmirs before dataize #83

#82 remove transpiled xmirs before dataize #83

Conversation

mximp commented Oct 14, 2022

mximp commented Oct 14, 2022

yegor256 commented Oct 14, 2022

mximp commented Oct 17, 2022 • edited Loading

yegor256 commented Oct 17, 2022

mximp commented Oct 17, 2022

mximp commented Oct 17, 2022

yegor256 commented Oct 17, 2022

rultor commented Oct 17, 2022

rultor commented Oct 17, 2022

mximp commented Oct 19, 2022

yegor256 commented Oct 19, 2022

rultor commented Oct 19, 2022

rultor commented Oct 19, 2022

volodya-lombrozo commented Oct 20, 2022

yegor256 commented Oct 20, 2022

rultor commented Oct 20, 2022

yegor256 commented Oct 20, 2022

rultor commented Oct 20, 2022

volodya-lombrozo commented Oct 20, 2022

yegor256 commented Oct 20, 2022

mximp commented Oct 20, 2022

mximp commented Oct 24, 2022

yegor256 commented Oct 24, 2022

rultor commented Oct 24, 2022

rultor commented Oct 24, 2022

mximp commented Oct 17, 2022 •

edited

Loading