Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81 #92

Closed
wants to merge 2 commits into from
Closed

81 #92

wants to merge 2 commits into from

Conversation

l3r8yJ
Copy link
Contributor

@l3r8yJ l3r8yJ commented Feb 27, 2023

closes #81

@yegor256 take a look, please

@l3r8yJ
Copy link
Contributor Author

l3r8yJ commented Feb 28, 2023

@yegor256 reminder

@yegor256
Copy link
Member

yegor256 commented Mar 1, 2023

@l3r8yJ now, since you don't call find_with_indent recursively, there is no need to have this function at all. We can just use find. Or I miss something?

@l3r8yJ
Copy link
Contributor Author

l3r8yJ commented Mar 1, 2023

@yegor256 take a look, please

I removed what you asked, but I think I misunderstood you?

continue;
}
format!("re to '{re}' didn't help")
trace!("#find(ν{v1}, {loc}): {indent}ν{v}.{k} relayed to {re}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l3r8yJ since we don't have recursion, no need to use indent, I believe

@l3r8yJ
Copy link
Contributor Author

l3r8yJ commented Jun 20, 2023

@yegor256 sorry for absence, how relevant is this pull request and issue?

@l3r8yJ l3r8yJ closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get rid of recursion in Sodg::find()
2 participants