Try to look for a target with "name" attribute #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblador
added a commit
that referenced
this pull request
Apr 23, 2015
Try to look for a target with "name" attribute
|
Looks good, thanks for the PR! |
|
Great! Could you release please so that I could use your module with this fix? |
oblador
added a commit
that referenced
this pull request
Apr 24, 2015
|
You made your changes in the compiled file unfortunately. I put it in the right file and made it work with the scrollSpy directive and released it as 0.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often happens, that anchors are targeting not the elements marked with
idattribute but ones which are marked withname. This is expected to work in browser according to the standard. So, I think it is nice to reflect this behavior.The use case:
Such a markup (with anchors targeting to the names) widely useful when generating md files with table of content. When inserting such a markup in the angular application, the anchors do not work even if using
duScroll. If you could merge this pull request, they will work :-) SC5/sc5-styleguide#599