Wait between retries when launching stories tab. #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 11, 2020
|
Any comment on this? |
oblador
reviewed
Mar 25, 2020
| @@ -17,6 +17,7 @@ const { | |||
| } = require('@loki/core'); | |||
| const presets = require('./presets.json'); | |||
|
|
|||
| const RETRY_LOADING_STORIES_TIMEOUT = 10000; | |||
There was a problem hiding this comment.
This value seems a bit high, how did you come up with it?
There was a problem hiding this comment.
I'll merge it as is now and we can follow up with tweaks if needed.
There was a problem hiding this comment.
I would’ve taken a lower value, but I would only do that if we did something like an exponential back off, start slow and iterate maybe 10 times, doubling the wait every time.
oblador
approved these changes
Mar 25, 2020
|
Released in [0.20.2](https://github.com/oblador/loki/releases/tag/v0.20.2]. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a common failure when doing
lokion CircleCI.Over 100 runs:
withRetries(2)This tries to fix 10% of the cases.
Over the last 2 weeks we have been testing this patch (> 200 builds) and have had ZERO failures!