Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump default chrome docker version #486

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Bump default chrome docker version #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install dependencies
run: yarn --frozen-lockfile --non-interactive --silent --ignore-scripts
- name: Prepare docker
run: docker pull yukinying/chrome-headless-browser-stable:100.0.4896.127
run: docker pull yukinying/chrome-headless-browser-stable:118.0.5993.117
- name: Run unit tests
run: yarn test-ci

Expand Down
4 changes: 2 additions & 2 deletions docs/command-line-arguments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ yarn loki test -- --port 9009
| **`--chromeAwsLambdaFunctionName`** | Name of the use to capture screenshots. | `loki` |
| **`--chromeAwsLambdaRetries`** | The number of retries for invoking the lambda, in case of failure. | `0` |
| **`--chromeConcurrency`** | How many stories to test in parallel when using chrome | `4` |
| **`--chromeDockerImage`** | What docker image to use when running chrome | `yukinying/chrome-headless-browser-stable:100.0.4896.127` |
| **`--chromeDockerWithoutSeccomp`** | Run chrome docker without custom seccomp settings. | `false` |
| **`--chromeDockerImage`** | What docker image to use when running chrome | `yukinying/chrome-headless-browser-stable:118.0.5993.117` |
| **`--chromeDockerWithoutSeccomp`** | Run chrome docker without unconfined seccomp settings. | `false` |
| **`--chromeDockerUseCopy`** | Use docker copy instead of volume mount for local stories | `false` |
| **`--chromeEnableAnimations`** | Enable CSS transitions and animations. | `false` |
| **`--chromeFlags`** | Custom chrome flags. | `--headless --disable-gpu --hide-scrollbars` |
Expand Down
2 changes: 1 addition & 1 deletion packages/runner/src/commands/test/default-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"chromeAwsLambdaBatchSize": "1",
"chromeAwsLambdaBatchConcurrency": "1",
"chromeConcurrency": "4",
"chromeDockerImage": "yukinying/chrome-headless-browser-stable:100.0.4896.127",
"chromeDockerImage": "yukinying/chrome-headless-browser-stable:118.0.5993.117",
"chromeFlags": "--headless --disable-gpu --hide-scrollbars",
"chromeLoadTimeout": "60000",
"chromeRetries": "0",
Expand Down
4 changes: 2 additions & 2 deletions packages/target-chrome-docker/src/create-chrome-docker-target.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const waitOnCDPAvailable = (host, port) =>

function createChromeDockerTarget({
baseUrl = 'http://localhost:6006',
chromeDockerImage = 'yukinying/chrome-headless-browser-stable:100.0.4896.127',
chromeDockerImage = 'yukinying/chrome-headless-browser-stable:118.0.5993.117',
chromeFlags = ['--headless', '--disable-gpu', '--hide-scrollbars'],
dockerNet = null,
dockerWithSudo = false,
Expand All @@ -62,7 +62,7 @@ function createChromeDockerTarget({
const execute = getExecutor(dockerWithSudo);

if (!chromeDockerWithoutSeccomp) {
runArgs.push(`--security-opt=seccomp=${__dirname}/docker-seccomp.json`);
runArgs.push('--security-opt=seccomp=unconfined');
}
runArgs.push('--add-host=host.docker.internal:host-gateway');

Expand Down
Loading
Loading